Add filter to theme editor accepted files

[pross]

Proposing adding a filter to theme-editor.php so theme authors can add to the list of files that are editable. ie html/less/js files.

Hers an example of what could be possible:

add_filter( 'wp_theme_editor_filetypes', 'add_my_filetype', 10, 2 );
function add_my_filetype( $allowed_types, $theme ) {
	
	$extra = $theme->get_files( 'less', 1 );
	return $allowed_types += $extra;
}

[MikeHansenMe]

Created a test.less file in my theme, added the patch and example. It worked great, I think this would be a good addition.

[SergeyBiryukov]

Related: #6531

[MikeHansenMe]

Refreshed with docs

[MikeHansenMe]

22924.diff​ is a refresh of theme-editor.php​ with docs.

[wonderboymusic]

In 35134:

Theme Editor: add a filter, wp_theme_editor_filetypes, to allow more filetypes to be edited via the Theme Editor. Usage of the Theme Editor is strenuously discouraged, but we should allow you to add whatever filetypes (.less, .scss) you would like.

Props MikeHansenMe, pross.
Fixes #22924.

[DrewAPicture]

Is the intention of the new wp_theme_editor_filetypes filter to make it possible to bring in arbitrary files or to expand the filetypes? Seems like based on the name alone we might be better off doing an array of file types then looping with $theme->get_files() on those types, e.g.

(pseudo)

<?php
/**
 * Filter the list of files allowed for editing in the Theme editor.
 *
 * @since 4.4.0
 *
 * @param array  $file_types List of file types.
 * @param object $theme      The current Theme object.
 */
$file_types = apply_filters( 'wp_theme_editor_filetypes', array( 'php', 'css' ), $theme );

foreach ( $file_types as $type ) {
        $allowed_files + $theme->get_files( $type );
}

...

if ( $allowed_files ) :
        if ( $theme->get_files( 'php' ) || $theme->parent() ) :
?>

The hook description also needs a little work, it's super vague.

[pross]

Replying to DrewAPicture:

Is the intention of the new wp_theme_editor_filetypes filter to make it possible to bring in arbitrary files or to expand the filetypes? Seems like based on the name alone we might be better off doing an array of file types then looping with $theme->get_files() on those types, e.g.

Original intention was to allow users the ability to edit .less files that were part of a theme.
The theme would add 'less' to the allowed filetypes using the filter.

[DrewAPicture]

Replying to pross:

Replying to DrewAPicture:

Is the intention of the new wp_theme_editor_filetypes filter to make it possible to bring in arbitrary files or to expand the filetypes? Seems like based on the name alone we might be better off doing an array of file types then looping with $theme->get_files() on those types, e.g.

Original intention was to allow users the ability to edit .less files that were part of a theme.
The theme would add 'less' to the allowed filetypes using the filter.

Precisely. The problem is that with this hook name it implies filetypes not files. So if the intention is to actually filter file types, something closer to my solution in comment:9 would probably be better-suited.

[SergeyBiryukov]

Replying to DrewAPicture:

The problem is that with this hook name it implies filetypes not files. So if the intention is to actually filter file types, something closer to my solution in comment:9 would probably be better-suited.

22924.2.diff​ implements comment:9. php and css cannot be removed, only new types can be added.

One issue with both [35134] and the patch is that new files are added under "Styles" heading, which doesn't make sense (see 22924.png​, where I've added txt as an example).

[SergeyBiryukov]

Replying to SergeyBiryukov:

One issue with both [35134] and the patch is that new files are added under "Styles" heading, which doesn't make sense (see 22924.png​, where I've added txt as an example).

22924.3.diff​ fixes that. Other types are displayed in their own section, see 22924.3.png​.

If new file types are added to the beginning of the array, before php, that section is displayed first.

[SergeyBiryukov]

Forgot to remove 'txt' from defaults in previous patch

[DrewAPicture]

@SergeyBiryukov: 22924.5.diff​:

• Removes txt type per your patch
• $theme is a WP_Theme object
• DRYs the base list of types
• Adds an array_unique() around the merge

[SergeyBiryukov]

In 35180:

Theme Editor: Repurpose the 'wp_theme_editor_filetypes' filter added in [35134] to actually filter file types instead of files.

Default types include 'php' and 'css' and cannot be removed, only new types can be added.

Props DrewAPicture, SergeyBiryukov.
Fixes #22924.