WordPress.org
Get WordPress

Make WordPress Core

Opened 10 years ago

Closed 10 years ago

#22931 closed defect (bug) (invalid)

Use double quotes for attribute values when loading JS in script-loader.php

Reported by: gish's profile gish Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: General Keywords:
Focuses: Cc:

Description

In /wp-includes/script-loader.php:685 script tags are built. The tags however have single quotes instead of double quotes, which doesn't conform to HTML5 standards.

Change History (2)

#1 follow-up: @dd32
10 years ago

The HTML5 standard accept 3 different formats:

id=example
id='example'
id="example"

single quotes are OK as per ​http://www.w3.org/TR/html-markup/syntax.html#attr-value-single-quoted

#2 in reply to: ↑ 1 @nacin
10 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to invalid
  • Status changed from new to closed

Replying to dd32:

The HTML5 standard accept 3 different formats:

Just adding that our own standards require either single or double quotes, and that no quotes is a big no-no for security reasons. (​http://www.wonko.com/post/html-escaping)

Note: See TracTickets for help on using tickets.