WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#22932 closed enhancement (fixed)

Change doctype for readme.html to HTML5

Reported by: gish Owned by: nacin
Milestone: 3.6 Priority: normal
Severity: normal Version:
Component: General Keywords: has-patch
Focuses: Cc:

Description

Since the administration panel and twentytwelve have doctype HTML5, there's no need for the readme.html document in the root to remain with the doctype XHTML.

Attachments (1)

readme.html.diff (470 bytes) - added by gish 3 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 @nacin3 years ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 3.6

Agreed.

comment:2 follow-up: @gish3 years ago

Can I help you out with this one?

comment:3 in reply to: ↑ 2 @nacin3 years ago

Replying to gish:

Can I help you out with this one?

Absolutely. You can create a patch, see http://make.wordpress.org/core/handbook/submitting-a-patch/

comment:4 @gish3 years ago

Alright, it's been attached. I assume you can add HTML5-specific elements. That would, however, require a shim for IE8.

comment:5 @nacin3 years ago

We still stick to the XHTML flavor of HTML5. So, we should continue to close self-closing elements. And no, we do not yet rely on HTML5-specific elements, as we don't really have a need for them (and still support down to IE7 in the admin).

@gish3 years ago

comment:6 follow-up: @gish3 years ago

I added a new patch with self-closing elements.

comment:7 @DrewAPicture3 years ago

  • Keywords has-patch added; needs-patch removed

comment:8 in reply to: ↑ 6 @rmccue3 years ago

Replying to gish:

I added a new patch with self-closing elements.

It looks like you may have replaced the first patch when uploading the new one. In general, we recommend against that so that we can see the history of them.

Otherwise, looks good!

comment:9 @nacin3 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 23188:

Convert to the HTML5 doctype for readme.html. props gish, fixes #22932.

Note: See TracTickets for help on using tickets.