Media manager inaccessible when dragging several images on Safari

[mario-siteground]

Browser: Version 6.0.2 (8536.26.17)

Target: The new media manager

Bug Description: After drag and dropping multiple images on the manager for upload, the manager becomes inaccessible.

Reason: In some cases the uploader-window fails to change display:block to display:none which makes everything on that page unclickable:

<div class="uploader-window" style="display: block; opacity: 0; "> <div class="uploader-window-content"> <h3>Drop files to upload</h3> </div> </div>

Since this is an external jQuery plugin used in Core and related to html5 structure, attached is the fix in the minified versions, as well as a standalone dev new version and the related code itself.

[mario-siteground]

dev version created

[mario-siteground]

min patched

[mario-siteground]

standalone bug

[SergeyBiryukov]

Looking at plupload.safari.patch​, this looks like something that should be fixed upstream.

[mario-siteground]

True. Related to this convo: ​https://irclogs.wordpress.org/chanlog.php?channel=wordpress-dev&day=2012-12-13&sort=asc#m518830

[nacin]

I created a patch based on ​https://github.com/moxiecode/plupload/tree/1.x. Can you explain your changes?

[nacin]

And, is this applicable to Safari for Windows only?

[MattyRob]

Replying to nacin:

And, is this applicable to Safari for Windows only?

I haven't seen this issue with Safari on OSX but what makes this strange is version 6.0.2 is the current release on OSX but it seems that version 5.1.7 is the current release of Safari on Windows (​http://en.wikipedia.org/wiki/Safari_version_history). Maybe we need some reporter feedback.

[azaozz]

Seems to be happening only on Safari/Windows, confirmed in 5.1.5. Can't reproduce in Safari/Mac 6.0.2.

Generally Plupload has always had some ​problems in Safari/Windows. The good news is that Plupload 2 is ​coming out soon-ish and will probably be in 3.6.

Not sure if we should patch plupload.html5.js. 22974.diff doesn't make any difference in Safari/Mac (obvious, as it runs only on Windows). In Safari/Windows 5.1.5 the patch prevents drag-drop completely (nothing happens after dropping files), without the patch drag-drop doesn't work (the first image is displayed in the browser).

Think best is to leave this for 3.6 when we will update to Plupload 2.

[tivnet]

Checked today with Safari 5.1.7, Windows 8.1, WordPress 3.8.1 - did not notice any problems.

[kovshenin]

Can't reproduce this issue specifically, but probably related: #27341

[helen]

Is this still an issue?

[azaozz]

No, Safari/Windows was discontinued years ago. Don't see a point in trying to fix this.