Remove deprecated jQuery methods from core to be safe for jQuery 1.9

[ocean90]

Today ​jQuery 1.9 Beta was released.

jQuery 1.9 has removed many of the items we deprecated during the last few versions of jQuery.
To test, we recommend that you start with the jQuery Migrate plugin since it will warn you about any deprecated features the code may depend on. Just include these two script tags in your code, replacing your existing jQuery script include:

<script src="http://code.jquery.com/jquery-1.9.0b1.js"></script>

<script src="http://code.jquery.com/jquery-migrate-1.0.0b1.js"></script>

The attached patch adds both scripts to core so that you can test it. There are already some notices which we should try to reduce.

[nacin]

In 23180:

Update to jQuery 1.9 Beta 1 in trunk (3.6-alpha).

Temporarily includes jQuery in original, unminified form, for ease of testing and bug reporting.

jQuery 1.9 introduces a "migrate" script for deprecated and removed behavior. Warnings are issued for methods we should not be using, and should be fixed in core. These warnings are sent to the JavaScript console and are collected in jQuery.migrateWarnings.

See ​http://blog.jquery.com/2012/12/17/jquery-1-9-beta-1-released/ for more.

props ocean90, see #22975.

[nacin]

Setting to needs-patch for removal of warnings.

Note that I needed to make a change to jQuery Migrate before landing it. PR here: ​https://github.com/jquery/jquery-migrate/pull/5.

[nacin]

Seems like the dependency tree in [23180] would break with concatenation. Migrate needs to load after jQuery, not before.

We should just place the migration code directly into jQuery core for now. If we need to keep it for plugins (which is likely the case), we can figure out a better way.

[nacin]

Anyone else imagining this as a good idea?

$scripts->add( 'jquery', false, array( 'jquery-core', 'jquery-noconflict', 'jquery-migrate' ) );
$scripts->add( 'jquery-core', ... );
$scripts->add( 'jquery-noconflict', ... );
$scripts->add( 'jquery-migrate', ... );

[trepmal]

Getting a Javascript error using Enter New on custom fields.

In screenshot, first 2 migrate notices are on page load, 3rd notice and error when clicking Enter New

[ocean90]

Replying to trepmal:

Getting a Javascript error using Enter New on custom fields.

That's already fixed upstream, see ​https://github.com/jquery/jquery-migrate/issues/4

[cklosows]

Also Seeing this when trying to use .toggle() for a show/hide within a plugin page. Was able to duplicate @trepmal's case as well.

TypeError: Cannot call method 'apply' of undefined ​http://localhost/wordpress/wp-includes/js/jquery/jquery-migrate.js?ver=1.0.0b1:349

[cklosows]

Replying to ocean90:

Replying to trepmal:

Getting a Javascript error using Enter New on custom fields.

That's already fixed upstream, see ​https://github.com/jquery/jquery-migrate/issues/4

Confirmed that fixed it. Thanks @ocean90

[trepmal]

22975-apply-fix.patch​ fixes the Enter New problem.

"Add Custom Field" (and Update for existing custom fields) button results in javascript error.

However, for new custom fields, the field is created and is then duplicated after updating/publishing/saving draft.

[nacin]

In 23182:

Update jQuery Migrate plugin to latest, fixing .toggle(boolean) usage. see #22975.

[nacin]

Here's the latest jQuery Migrate (live) — ​http://code.jquery.com/jquery-migrate-git.js. That's what [23182] applies. I didn't even see the chatter on this ticket committing, as one of the lead jQuery developers alerted me. He's very happy to see that we got some testers. :-)

[TobiasBg]

Replying to nacin:

Seems like the dependency tree in [23180] would break with concatenation. Migrate needs to load after jQuery, not before.

I can't reproduce problems with this. http://localhost/wp-admin/load-scripts.php?c=0&load[]=jquery-migrate,jquery,utils&ver=3.6-alpha works fine, jQuery is first (with .noConflict(); at the end), then jquery-migrate.js.

Replying to nacin:

$scripts->add( 'jquery-noconflict', ... );

This should also get a dependency on jquery-core. This would allow plugins to enqueue jQuery without jquery-migrate, if it is sure that it doesn't need the backwards compatibility part.

[nacin]

In 23183:

Have the 'jquery' script handle be a parent of both jQuery core and jQuery Migrate. see #22975.

[markmcwilliams]

Replying to nacin:

In 23183:

Have the 'jquery' script handle be a parent of both jQuery core and jQuery Migrate. see #22975.

Should the version not be updated as per [23182] or will it not matter at this early stage?

[SergeyBiryukov]

Replying to trepmal:

"Add Custom Field" (and Update for existing custom fields) button results in javascript error.

Confirmed. The error happens at the very beginning of wpList.add():
​http://core.trac.wordpress.org/browser/tags/3.5/wp-includes/js/wp-lists.js#L310

Seems that jQuery 1.9 has a problem if the string starts with \n. Also reproduced with this fiddle: ​http://jsfiddle.net/VnCrU/.

22975.custom-fields.patch​ fixes the error.

[cdog]

Replying to SergeyBiryukov:

22975.custom-fields.patch​ fixes the error.

It fixes the error but throws the following warning:

JQMIGRATE: $(html) HTML strings must start with '<' character

Removing both leading characters \n\t as shown in attachment:22975.custom-fields.diff​ seems to get rid of the warning too.

Edit: Is there any reason for using those special characters at the beginig of each concatenated string? Removing them would produce the same results making the code more readable.

[SergeyBiryukov]

Replying to SergeyBiryukov:

Seems that jQuery 1.9 has a problem if the string starts with \n. Also reproduced with this fiddle: ​http://jsfiddle.net/VnCrU/.

Appears to be a result of the fix in ​http://bugs.jquery.com/ticket/11290.

[cdog]

Please take a look at: attachment:22975.custom-fields.2.diff​. I think a better approach would be to trim leading spaces as noted in ​http://bugs.jquery.com/ticket/11290#comment:4. Should also solve similar issues if they exist.

[SergeyBiryukov]

With proper formatting

[nacin]

A developer using wp_localize_script( 'jquery', ... ) (to inexplicably pass values to, well, I don't know, they're doing it wrong) will find that their code breaks now.

[ocean90]

Attached a patch for jQuery 1.9 RC1. Includes also the updated version of the Migrate script. I used the git Version since it includes already ​a new fix.

[ocean90]

#23204 was marked as a duplicate.

[ocean90]

Patch for 1.9 final: ticket:23204:jquery.diff​

[nacin]

In 23301:

jQuery 1.9 final. jQuery Migrate 1.0. Uncompressed for now, while we iron out kinks.

props jorbin. see #22975.

[Lwangaman]

jQuery 1.9 has specifically deprecated the methods ".live()" and ".browser()" in favour of ".on()" and ".support()" respectively.
This breaks "wp-includes/js/admin-bar.js" (or "wp-includes/js/admin-bar.min.js") which makes use of the "$.browser()" method to target Mozilla. Hovering over admin bar items when using jQuery 1.9 results in these errors in the console:
Uncaught TypeError: Cannot read property 'mozilla' of undefined ---- admin-bar.min.js:1
It will be necessary to target the specific functionality of mozilla that is different from other browsers in order to use "$.support()".

[ocean90]

22975.patch​ adds ​jQuery Migrate 1.1.0.

[wonderboymusic]

#23388 was marked as a duplicate.

[SergeyBiryukov]

jquery.1.9.1.diff​ fixes the error when adding or updating custom fields (comment:17).

[nacin]

In 23421:

jQuery 1.9.1 and jQuery Migrate 1.1.0.

Remains uncompressed for now, until we work out all 1.9.x issues.
Fixes custom fields.

props ocean90, wonderboymusic. see #22975.

[ocean90]

I will start to replace the deprecated methods now.

[ocean90]

I have started with the ​.live() event.

$ ack ".live\(" -l --ignore-dir=wp-content
wp-admin/js/categories.js
wp-admin/js/inline-edit-post.js
wp-admin/js/inline-edit-tax.js
wp-admin/js/post.js
wp-admin/js/tags.js
wp-includes/js/jquery/jquery-migrate.js
wp-includes/js/swfupload/handlers.js
wp-includes/js/thickbox/thickbox.js

22975.replace-live.patch​ adresses

• wp-admin/js/inline-edit-post.js
• wp-admin/js/inline-edit-tax.js
• wp-admin/js/post.js
• wp-admin/js/tags.js

I ignored external libs like Thickbox. wp-admin/js/categories.js isn't used anymore, see #23486.

wp-admin/js/post.js: I have no idea what these lines should do, it seems that it does nothing. Sergey gave me the hint.

[ocean90]

Next: ​$.browser

ack "(\\$|jQuery)\.browser" --ignore-dir=wp-content -l
wp-admin/js/color-picker.js
wp-includes/js/admin-bar.js
wp-includes/js/autosave.js
wp-includes/js/imgareaselect/jquery.imgareaselect.js
wp-includes/js/jquery/jquery-migrate.js
wp-includes/js/jquery/jquery.hotkeys.js
wp-includes/js/jquery/suggest.js
wp-includes/js/thickbox/thickbox.js

wp-admin/js/color-picker.js is handled in #23484.

wp-includes/js/admin-bar.js uses $.browser to detect WebKit to fix the focus bug. See [22249].

wp-includes/js/autosave.js uses $.browser to detect Safari. See #18341.

[nacin]

In 23444:

Stop using jQuery.live(). props ocean90. see #22975.

[nacin]

Let's also patch Thickbox. It is dead upstream.

[ocean90]

Replying to nacin:

Let's also patch Thickbox. It is dead upstream.

.live() is done in 22975.thickbox.patch​.

In 22975.browser.patch​ I have replaced the jQuery.browser calls with navigator.userAgent. Except in Thickbox - It would work without the two lines, but I leave it in, since it seems not to hurt.

[ocean90]

There is another jQuery.browser call in admin-bar.js. It's in the hoverintent lib. Added in [18488]. Looking at the ​original version there seems not to be such a call. Will talk to azaozz.

[ocean90]

22975.consolidated.patch​ combines 22975.thickbox.patch and 22975.browser.patch​. And updates hoverIntent to r6, see [19605].

[ocean90]

jquery.migrate.1.1.1.patch​:

​http://blog.jquery.com/2013/02/16/jquery-migrate-1-1-1-released/

[SergeyBiryukov]

In [23444], the selector in post.js appears to be redundant: 22975.taxonomy-checklist.patch​.

[ocean90]

Replying to SergeyBiryukov:

In [23444], the selector in post.js appears to be redundant: 22975.taxonomy-checklist.patch​.

Yeah, just saw that I have added the wrong patch which has included the console.log() call.

One small disadvantage is, that the event is now fired for each checkbox, not only the popular ones. We could add some parent element checks, but IMO the current way is not such harmful.

[azaozz]

...but IMO the current way is not such harmful.

As far as I remember that bit of JS was causing slow running problems in (older) IE when there are a lot of categories. Probably better to keep it on the "popular" checkboxes only.

[ocean90]

Replying to azaozz:

As far as I remember that bit of JS was causing slow running problems in (older) IE when there are a lot of categories. Probably better to keep it on the "popular" checkboxes only.

The performance one was r21737, see comment:ticket:21106:16. It had used previously :checkbox, which was replaced with [type="checkbox"]. So the change should be okay - Sergey, can you confirm?

[azaozz]

Replying to ocean90:

You're right. It also doesn't need the two selectors as we are looking at all checkboxes in the two <ul>:

.on( 'click', 'input[type="checkbox"]', function() {...

would be better (that JS and postbox really needs redoing).

[SergeyBiryukov]

Replying to ocean90:

One small disadvantage is, that the event is now fired for each checkbox, not only the popular ones.

Would 22975.taxonomy-checklist.2.patch​ make more sense then?

The performance one was r21737, see comment:ticket:21106:16. It had used previously :checkbox, which was replaced with [type="checkbox"]. So the change should be okay - Sergey, can you confirm?

Correct.

[ocean90]

22975.taxonomy-checklist.patch​ won't work, because li.popular-category can be added after the DOM is ready.

Commit candidates:

• 22975.consolidated.patch​
• 22975.taxonomy-checklist.2.patch​
• jquery.migrate.1.1.1.patch​

[nacin]

In 23516:

jQuery Migrate 1.1.1. props ocean90. see #22975.

[nacin]

In 23517:

Imporove a selector targeting taxonomy meta boxes. props SergeyBiryukoc. see #22975.

[nacin]

In 23518:

Stop using deprecated jQuery API (.browser and .live). Do manual UA sniffing where still necessary. Improve selector performance by using delegated events. props ocean90. see #22975.

[nacin]

In 23536:

Imporove a selector targeting taxonomy meta boxes. props SergeyBiryukov. see #22975.

Uses correct patch, reverting [23517].

[SergeyBiryukov]

Not sure why [23517] got reverted. Per comment:47, 22975.taxonomy-checklist.2.patch​ is the correct patch.

[nacin]

Replying to SergeyBiryukov:

Not sure why [23517] got reverted. Per comment:47, 22975.taxonomy-checklist.2.patch​ is the correct patch.

ocean90 had sent me a note — he mixed up the two patches in that comment. .2 wouldn't work. The first one does. Hence the swap.

[SergeyBiryukov]

Replying to ocean90:

One small disadvantage is, that the event is now fired for each checkbox, not only the popular ones.

Seems like 22975.taxonomy-checklist.3.patch​ would be the correct optimization here. We only want the checkbox synchronization between "All Categories" and "Most Used" tabs to fire when clicking on a popular category itself, not on its child categories (like before [23444]) or any category (like now).

[SergeyBiryukov]

Replying to SergeyBiryukov:

Seems that jQuery 1.9 has a problem if the string starts with \n. Also reproduced with this fiddle: ​http://jsfiddle.net/VnCrU/.

Appears to be a result of the fix in ​http://bugs.jquery.com/ticket/11290.

Custom fields (comment:11) and menus (#23681) are affected.

In current trunk it's a console message rather than a JS error thanks to jQuery Migrate 1.1.0 ([23421]).

[ocean90]

ToDo: trunk/wp-includes/js/jquery/suggest.js

[ocean90]

Replying to SergeyBiryukov:

Seems like 22975.taxonomy-checklist.3.patch​ would be the correct optimization here. We only want the checkbox synchronization between "All Categories" and "Most Used" tabs to fire when clicking on a popular category itself, not on its child categories (like before [23444]) or any category (like now).

Committed in [24116].

[anastis]

Replying to nacin:

Anyone else imagining this as a good idea?

$scripts->add( 'jquery', false, array( 'jquery-core', 'jquery-noconflict', 'jquery-migrate' ) );
$scripts->add( 'jquery-core', ... );
$scripts->add( 'jquery-noconflict', ... );
$scripts->add( 'jquery-migrate', ... );

This seems to have make it into beta 2 in the form:

$scripts->add( 'jquery', false, array( 'jquery-core', 'jquery-migrate' ) );
$scripts->add( 'jquery-core', '/wp-includes/js/jquery/jquery.js', array(), '1.9.1' );
$scripts->add( 'jquery-migrate', '/wp-includes/js/jquery/jquery-migrate.js', array(), '1.1.1' );

Is the jquery-migrate plugin going to be removed in 3.6 or in some future version?

Also, I've seen some plugins (notably WooCommerce) checking for the jQuery version like this:

if ( isset( $wp_scripts->registered['jquery']->ver ) && $wp_scripts->registered['jquery']->ver < '1.7' )

Perhaps it would be a good idea to add a version number to 'jquery' so that this kind of code remains functional?

[ocean90]

In 24252:

jQuery Migrate 1.2.1. see #22975.

[aaroncampbell]

22975.diff​ adds the jquery-core version to jquery. This will fix the issue brought up in comment 60

[ryan]

Looks good.

[markjaquith]

In 24314:

Add the jQuery version to the 'jquery' script alias

• Allows people to check it and get the right result

see #22975. props aaroncampbell.

[ocean90]

comment:57

[ocean90]

22975.suggest.patch​ removes the IE browser check since the method .bgiframe() on $result has no function because the method doesn't exist.

And it removes the check for Mozilla. keydown works for me in all browsers. Tested also via Browserstack down to Firefox 3.6.

[markjaquith]

Looks good to me. Go for it.

[ocean90]

In 24371:

Remove deprecated jQuery API .browser in suggest.js. No need for a replacement since it works without too. see #22975.

[wonderboymusic]

Can someone tell Akismet to stop using .live()?