WordPress.org

Make WordPress Core

Opened 19 months ago

Last modified 5 months ago

#22984 new enhancement

Media Modal - Auto-save for compat-items doesn't trigger the UI to show the spinner or "Saved" indicators.

Reported by: eddiemoya Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 3.5
Component: Media Keywords: needs-patch
Focuses: ui Cc:

Description

When the auto-save kicks in for the standard attachment editor fields, it triggers the spinner icon in the top right corner. This is followed by "Saved" which then disappears on its own. None of these UI indicators are triggered for custom input items added via the 'attachment_fields_to_edit hook.

Not sure if its was an oversight or simply not seen as important.

Change History (4)

comment:1 sabreuse18 months ago

  • Component changed from UI to Media
  • Keywords ui-focus added

comment:2 ocean905 months ago

  • Keywords needs-patch added

Hello eddiemoya, sorry you never got a response.

You're right. There is no save indicator for compat-items. We should try to re-use the existing indicator. I'll take a stab on this.

comment:3 follow-up: DrewAPicture5 months ago

CMIIW, but it was my impression that the reason the spinner didn't activate is because the compat fields weren't being auto-saved like the default fields. The only way those fields would be saved would be on update.

comment:4 in reply to: ↑ 3 ocean905 months ago

Replying to DrewAPicture:
The compat section has it's own view and is decoupled from the view with the spinner. So it's not that easy as I thought. The spinner should get it's own view.

But the fields are autosaved too, see trunk/src/wp-includes/js/media-views.js#L4954

Note: See TracTickets for help on using tickets.