WordPress.org

Make WordPress Core

Opened 8 years ago

Closed 8 years ago

#22991 closed enhancement (fixed)

nav-menu tabs turn into a select when there are too many menus

Reported by: Sverigedemokraterna IT Owned by:
Milestone: 3.6 Priority: normal
Severity: normal Version:
Component: Menus Keywords:
Focuses: Cc:

Description

The menu editor tab bar isn't a very effective way to select menus if you have, say, 10 or 20 menus or so. This patch changes the tab bar to a select + button in a form.

Things to note:

  • The define (5) is arbitrary and can perhaps be placed elsewhere.
  • Using a GET was the smartest way of selecting another menu, while at the same time remaining accessibility-friendly.
  • Using the GET causes the button to end up on the address bar also. This could have been avoided if the submit button could have the button text and the value separately (perfect value is "edit"), but that's HTML for you.
  • I'm unsure of correct CSS styling.

Attachments (1)

nav-menus.21383.diff (1.8 KB) - added by Sverigedemokraterna IT 8 years ago.
Changes tab bar to a select if there are too many menus

Download all attachments as: .zip

Change History (8)

@Sverigedemokraterna IT
8 years ago

Changes tab bar to a select if there are too many menus

#1 @johnbillion
8 years ago

+1 for the idea. We definitely need a better way of presenting menus when there are a large number of them.

#2 follow-up: @nacin
8 years ago

  • Cc lessbloat added
  • Keywords ux-feedback added
  • Milestone changed from Awaiting Review to 3.6

I think we should remove the tabs all together. User testing will likely validate that the tabs greatly confuse users into thinking they are the menu itself.

#3 @knutsp
8 years ago

  • Cc knut@… added

#4 in reply to: ↑ 2 @lessbloat
8 years ago

Replying to nacin:

I think we should remove the tabs all together. User testing will likely validate that the tabs greatly confuse users into thinking they are the menu itself.

No sign of trouble with the first two user tests. But I agree, this could very likely be designed better.

#5 @helen
8 years ago

  • Keywords ui-focus added

#7 @lessbloat
8 years ago

  • Keywords ux-feedback ui-focus removed
  • Resolution set to fixed
  • Status changed from new to closed

We removed tabs completely in #23119.

Note: See TracTickets for help on using tickets.