WordPress.org
Get WordPress

Make WordPress Core

Opened 12 years ago

Closed 5 years ago

#22994 closed enhancement (fixed)

Remove 'blogroll' from the import options

Reported by: ipstenu's profile Ipstenu Owned by: hareesh-pillai's profile hareesh-pillai
Milestone: 5.4 Priority: normal
Severity: normal Version: 3.5
Component: Import Keywords: has-patch has-ux-feedback commit
Focuses: administration Cc:

Description

Now that we've dropped links (#21307), we shouldn't encourage importing them. It'll just confuse the newbies.

This will require a change to ​http://api.wordpress.org/core/importers/1.0/, so while we can clean up /wp-admin/includes/import.php (attached) it won't matter till that's scrubbed. Maybe upgrade that to 1.1 so people who are on older WP are left alone?

Attachments (2)

22994.diff​ (653 bytes) - added by Ipstenu 12 years ago.
removing opml from the import file
22994.1.diff​ (633 bytes) - added by Hareesh Pillai 5 years ago.
Patch refreshed

Download all attachments as: .zip

Change History (18)

@Ipstenu
12 years ago

removing opml from the import file

#1 @SergeyBiryukov
12 years ago

  • Component changed from General to Import

#2 @DrewAPicture
12 years ago

  • Cc xoodrew@… added
  • Keywords ux-feedback added

Seems sensible to me. I'd be tempted took hook display to whether they have the plugin enabled or are still running the legacy version though.

#3 @SergeyBiryukov
11 years ago

  • Milestone changed from Awaiting Review to WordPress.org

#4 in reply to: ↑ description @nacin
11 years ago

  • Owner set to nacin
  • Status changed from new to accepted

Replying to Ipstenu:

Maybe upgrade that to 1.1 so people who are on older WP are left alone?

I planned ahead. The endpoint receives the version number. :)

#5 @chriscct7
9 years ago

  • Focuses administration added

This ticket was mentioned in ​Slack in #design by karmatosed. ​View the logs.
7 years ago

#7 @karmatosed
7 years ago

  • Keywords has-ux-feedback added; ux-feedback removed

We talked about this in the weekly design triage and would encourage this to happen.

#8 @audrasjb
5 years ago

  • Owner changed from nacin to hareesh-pillai
  • Status changed from accepted to assigned

Reassigning the ticket to @hareesh-pillai: they asked to own the ticket to help it to go ahead.

@Hareesh Pillai
5 years ago

Patch refreshed

#9 @SergeyBiryukov
5 years ago

  • Milestone changed from WordPress.org to 5.3

Created ​#meta4706 for the API change.

This ticket was mentioned in ​Slack in #core by hareesh-pillai. ​View the logs.
5 years ago

#11 @JeffPaul
5 years ago

  • Keywords needs-testing added
  • Milestone changed from 5.3 to Future Release

With 5.3 Beta 1 shipping today, I'm punting this to Future Release so as not to clog up the 5.4 milestone. However, @hareesh-pillai as the ticket owner feel free to move to 5.4 if you feel comfortable committing to resolving this fully then... thanks!

#12 @dd32
5 years ago

I've committed the change on api.wordpress.org to not show it in 5.3+. The list in Core is only used as a fallback in the event the API is unreachable (and to allow translations of the importer names/descriptions)

What's the opinion here - Should I leave it as-is, revert, or bump it to not show fo 5.4+ instead?

Version 0, edited 5 years ago by dd32 (next)

#13 @SergeyBiryukov
5 years ago

  • Milestone changed from Future Release to 5.4

This ticket was mentioned in ​Slack in #core by david.baumwald. ​View the logs.
5 years ago

#15 @garrett-eclipse
5 years ago

  • Keywords commit added; needs-testing removed

Testing this applies cleanly and the unit tests run. The Blogroll entry already isn't showing due to the api change so remove this will have no visual affect. Marking for commit to clean this up in core.

#16 @SergeyBiryukov
5 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 47227:

Import: Remove "Blogroll" import option (for links in OPML format) from the list of popular importer plugins.

Link Manager is disabled for new installations since WordPress 3.5, so core should not encourage importing links.

See ​#meta4706 for the corresponding WordPress.org API change.

Props Ipstenu, hareesh-pillai, DrewAPicture, nacin, karmatosed, dd32, garrett-eclipse.
Fixes #22994. See #21307.

Note: See TracTickets for help on using tickets.