Make WordPress Core

Opened 14 years ago

Closed 12 years ago

#23003 closed defect (bug) (fixed)

Long filename breaks styling in media modal

Reported by: pavelevap Owned by: johnbillion
Priority: normal Milestone: 4.1
Component: Media Version: 3.5
Severity: normal Keywords: has-patch
Cc: Focuses: ui

Description

Long filename in media modal breaks styling of right sidebar. Long filename is displayed bellow thumbnail and longer labels bellow are moved to separate line.

See attached picture.

Attachments (4)

Long_filename.jpg​ (29.3 KB ) - added by pavelevap 14 years ago.
Screen Shot 2014-06-08 at 3.52.05 PM.png​ (30.7 KB ) - added by ramiabraham 12 years ago.
Screenshot of newly-added break-word and width setting
media-views.diff​ (407 bytes ) - added by ramiabraham 12 years ago.
add break-word to .name class, set max-width for data-setting="alt"
media-views--rev.diff​ (387 bytes ) - added by ramiabraham 12 years ago.
Removes the [data-setting="alt"] attribute.

Download all attachments as: .zip

Change History (13)

#1 @helen
14 years ago

  • Milestone Awaiting Review
  • Resolution → invalid
  • Status new → closed

I believe this is all intentional.

#2 @pavelevap
14 years ago

  • Resolution invalid
  • Status closed → reopened

I do not think so. I probably described it a little messy. Yes, filename is bellow thumbnail (no problem), but why "Alt Text" field is bellow Alt Text label (localized) when it works well if filename is shorter?

#3 @SergeyBiryukov
14 years ago

  • Milestone → Awaiting Review

The image on the right has smaller width, probably due to a scroll bar not shown in the screenshot.

Wrapping the text in the left column would probably look better than shifting the inputs down.

Last edited 14 years ago by SergeyBiryukov (previous) (diff)

#4 @alexvorn2
14 years ago

I think this is by design

#5 @ericlewis
12 years ago

  • Focuses ui added
  • Keywords needs-patch added

@ramiabraham
12 years ago

Screenshot of newly-added break-word and width setting

@ramiabraham
12 years ago

add break-word to .name class, set max-width for data-setting="alt"

#6 @ramiabraham
12 years ago

  • Keywords has-patch added; needs-patch removed

Added word-wrap: break-word to
.media-sidebar .setting .name and specified a max-width for .setting[data-setting="alt"] .name

The min-width: 30%; is retained for .media-sidebar .setting .name, as a flexible width is needed for some elements.


#7 @ramiabraham
12 years ago

Actually, the span class .name is not present in .media-sidebar .setting when there's also an input[type="checkbox"] (as a sibling of the span), so the [data-setting="alt"] attribute can be removed, which will allow the word-wrap to affect all span.name classes within .media-sidebar .setting.

@ramiabraham
12 years ago

Removes the [data-setting="alt"] attribute.

#8 @wonderboymusic
12 years ago

  • Milestone Awaiting Review → 4.1

#9 @johnbillion
12 years ago

  • Owner set to johnbillion
  • Resolution → fixed
  • Status reopened → closed

In 30359:

Correctly wrap the text in long input labels in the media manager.

Fixes #23003
Props ramiabraham

Note: See TracTickets for help on using tickets.