Context Navigation

← Previous Ticket
Next Ticket →

#23040 assigned enhancement

Deprecate magic methods isset() & get() method of WP_Theme object

Reported by:	wpsmith	Owned by:
Priority:	normal	Milestone:	Future Release
Component:	Themes	Version:	3.4
Severity:	normal	Keywords:	has-patch needs-refresh
Cc:		Focuses:

Description

Currently, a user can do the following:

$theme   = wp_get_theme();
$version = $theme->Version;
$name    = $theme->Name;
$author  = $theme->Author;
$version = $theme->Version;

So, when I tried to get the other data in the same method, I was getting nothing. However, to get the other data, one must do this:

$theme->{'Author URI'}; // per Codex;
$theme->get( 'AuthorURI' ); // $theme->AuthorURI doesn't work
$theme->get( 'ThemeURI' ); // $theme->ThemeURI & $theme->{'Theme URI'}; doesn't work
$theme->get( 'TextDomain' ); // $theme->TextDomain & $theme->{'Text Domain'}; doesn't work

get() is a great method to get the other data; however, shouldn't we make this consistent for developers?

Attachments (2)

class-wp-theme.php.patch (3.1 KB ) - added by wpsmith 13 years ago.: Deprecating methods
23040.r1.patch (2.9 KB ) - added by wpsmith 12 years ago.: Refreshed

Download all attachments as: .zip

Change History (13)

#1 in reply to: ↑ description @wpsmith
14 years ago

Updated the Codex Examples

#2 @scribu
14 years ago

Summary Expand use of WP_Theme object → Expand __get() method of WP_Theme object

#3 @scribu
14 years ago

Type defect (bug) → enhancement

#4 @nacin
14 years ago

The doc block for __get() says it is "for properties formerly returned by current_theme_info()". What it should also mention is this is deprecated functionality. So is offsetExists(), which implements ArrayAccess.

get() and display() are the proper methods to use. The property ($theme->property) and key ($theme['property']) ways of getting data should realistically be deprecated, as they have ambiguous and inconsistent behavior.

@wpsmith
13 years ago

Attachment class-wp-theme.php.patch added

Deprecating methods

#5 @wpsmith
13 years ago

Updated Codex to only use the get() method. Added _doing_it_wrong() notifications to the magic methods __isset() & __get() and _deprecated_function() notification to offsetExists().

Last edited 13 years ago by wpsmith (previous) (diff)

#6 @wpsmith
13 years ago

Summary Expand __get() method of WP_Theme object → Deprecate magic methods __isset() & __get() method of WP_Theme object

#7 @obenland
12 years ago

Keywords needs-refresh added; 2nd-opinion dev-feedback removed
Milestone Awaiting Review → Future Release
Version → 3.4

@wpsmith
12 years ago

Attachment 23040.r1.patch added

Refreshed

#8 @wpsmith
12 years ago

Keywords dev-feedback has-patch added; needs-refresh removed

#9 @chriscct7
11 years ago

Keywords needs-refresh added

#10 @swissspidy
9 years ago

Keywords dev-feedback removed
Owner set to swissspidy
Status new → assigned

#11 @swissspidy
5 years ago

Owner swissspidy removed

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core

Context Navigation

#23040 assigned enhancement

Deprecate magic methods __isset() & __get() method of WP_Theme object

Description

Attachments (2)

Change History (13)

#1 in reply to: ↑ description @wpsmith 14 years ago

#2 @scribu 14 years ago

#3 @scribu 14 years ago

#4 @nacin 14 years ago

@wpsmith 13 years ago

#5 @wpsmith 13 years ago

#6 @wpsmith 13 years ago

#7 @obenland 12 years ago

@wpsmith 12 years ago

#8 @wpsmith 12 years ago

#9 @chriscct7 11 years ago

#10 @swissspidy 9 years ago

#11 @swissspidy 5 years ago