WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 22 months ago

#23051 closed defect (bug) (fixed)

Menu with navigation label '0' gets removed

Reported by: zsero Owned by: SergeyBiryukov
Milestone: 3.6 Priority: normal
Severity: normal Version:
Component: Menus Keywords: has-patch commit
Focuses: Cc:

Description

There is no way to save a menu item with Navigation Label = 0 (zero). It gets removed. I think it's a bug in an if statement where 0 happens to be False or something similar.

Attachments (3)

23051.diff (473 bytes) - added by MikeHansenMe 2 years ago.
change empty to ! isset
23051.2.diff (1.3 KB) - added by kovshenin 2 years ago.
23051.3.diff (1.7 KB) - added by SergeyBiryukov 22 months ago.

Download all attachments as: .zip

Change History (12)

comment:1 @SergeyBiryukov2 years ago

  • Component changed from General to Menus

comment:2 @toscho2 years ago

  • Cc info@… added

@MikeHansenMe2 years ago

change empty to ! isset

comment:3 @MikeHansenMe2 years ago

  • Cc mdhansen@… added
  • Keywords has-patch needs-testing added

comment:4 @SergeyBiryukov2 years ago

  • Milestone changed from Awaiting Review to 3.6

@kovshenin2 years ago

comment:5 @kovshenin2 years ago

In 23051.2.diff do a string length comparison, rather than empty or isset. Also refreshed for current trunk since things have moved around in menus. Or maybe it's just easier to compare to an empty string?

Last edited 2 years ago by kovshenin (previous) (diff)

comment:6 @MikeHansenMe22 months ago

Just tested 23051.2.diff and it still applies to current trunk(3.6-beta2-24227).

@SergeyBiryukov22 months ago

comment:7 @SergeyBiryukov22 months ago

I think we should have isset() in some of those checks.

23051.3.diff also simplifies the logic in wp_update_nav_menu_item().

comment:8 @SergeyBiryukov22 months ago

  • Keywords commit added; needs-testing removed

comment:9 @SergeyBiryukov22 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 24235:

Prevent menu items with '0' label from being removed on menu saving. props MikeHansenMe, kovshenin. fixes #23051.

Note: See TracTickets for help on using tickets.