Post Becomes Unprotected (Password) Without Explicit Permission

[AKTed]

When you edit a post that's password protected and click 'Edit' next to 'Visibility: Password Protected', if you click 'Cancel' (still shows as 'Password Protected') then subsequently 'Update' it will change the visibility to 'Public'.

If you look closely, right after you click 'Cancel', while the section is collapsing, you'll see the password disappear. But it still says 'Visibility: Password Protected'.

[miqrogroove]

Tested and confirmed in both 3.5 and 3.4.2.

[thomasvanderbeek]

Fixed #23065

[SergeyBiryukov]

Tickets are marked as fixed when a change is made to the WordPress codebase which fixes the issue.

[MikeHansenMe]

Tested the patch on 3.6-alpha-23223. Fixes typo, correcting the problem.

[nacin]

I tracked this down to at least 2.8. hidden_post_password is the name, hidden-post-password appears to have always been the ID.

[SergeyBiryukov]

Introduced in [9639]. patch_commit_1bf7f3273cb1.patch​ looks proper.

[thomasvanderbeek]

This patch is more consistent with the rest of the code conventions.

[SergeyBiryukov]

patch_commit_f941f7f69a79.patch​ would also require changes in CSS and JS:
​http://core.trac.wordpress.org/browser/tags/3.5/wp-admin/css/wp-admin.css#L3228
​http://core.trac.wordpress.org/browser/tags/3.5/wp-admin/js/post.js#L479

I guess it's better to leave post_password ID as is, for backwards compatibility reasons. A similar change was suggested for Dashboard in #17555.

patch_commit_1bf7f3273cb1.patch​ is enough to fix the issue.

[SergeyBiryukov]

In 23338:

Prevent an unintended visibility change from "Password protected" to "Public" when updating the post.

props thomasvanderbeek. fixes #23065.

[SergeyBiryukov]

#23633 was marked as a duplicate.

[helen]

#23633 was marked as a duplicate.