WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#23071 closed defect (bug) (fixed)

Arrows in sort-2x.gif are too big and overlap

Reported by: TobiasBg Owned by: ryan
Milestone: 3.5.1 Priority: normal
Severity: normal Version: 3.5
Component: Administration Keywords: has-patch commit fixed-major
Focuses: ui Cc:

Description

In the HiDPI version of the sort arrows (e.g. in the head row of WP_List_Tables), the individual arrows are too big and extend beyond the center of the image.

The attached screenshot (zoomed in on iPad 3) shows that the lower right corner is missing, while the corner of the down arrow is already showing in the top right corner.

Attachments (3)

screenshot.jpg (46.1 KB) - added by TobiasBg 3 years ago.
Arrows in sort-2x.gif extend beyond horizontal center of the image
sort-2x.gif (100 bytes) - added by lessbloat 3 years ago.
sort-2x-alt.gif (97 bytes) - added by lessbloat 3 years ago.

Download all attachments as: .zip

Change History (13)

@TobiasBg3 years ago

Arrows in sort-2x.gif extend beyond horizontal center of the image

comment:1 @nacin3 years ago

  • Component changed from General to Administration

comment:2 @nacin3 years ago

  • Milestone changed from Awaiting Review to 3.5.1

comment:3 @JustinSainton3 years ago

  • Summary changed from Arrows in sort-2x.gif are to big and overlap to Arrows in sort-2x.gif are too big and overlap

comment:4 @SergeyBiryukov3 years ago

  • Keywords ui-focus added

@lessbloat3 years ago

comment:5 @lessbloat3 years ago

sort-2x.gif​ should fix this.

@lessbloat3 years ago

comment:6 @lessbloat3 years ago

sort-2x-alt.gif​ as an alternative removes the double solid baseline for each arrow. Here's a comparison of the two:

http://f.cl.ly/items/3A2a2L1q0p0q300m2644/arrow-comparison.gif

comment:7 @helen3 years ago

  • Keywords has-patch added; needs-patch removed

sort-2x-alt.gif looks nice to me.

comment:8 @nacin3 years ago

In 23245:

Fix the sprite positioning for HiDPI sorting arrows.

props lessbloat.
see #23071.
for trunk.

comment:9 @nacin3 years ago

  • Keywords commit fixed-major added

Debating whether to bother with a CSS version bump for the 3.5 branch.

comment:10 @ryan3 years ago

  • Owner set to ryan
  • Resolution set to fixed
  • Status changed from new to closed

In 23287:

Fix the sprite positioning for HiDPI sorting arrows.

props lessbloat.
fixes #23071.
for 3.5.

Note: See TracTickets for help on using tickets.