Update menu item title when editing menu item label

[tillkruess]

I'd like to suggest that the menu item title gets updated when the user is editing the "Navigation Label" field. That results in a nicer preview, when the menu item is collapsed again before saving.

[wonderboymusic]

With a patch, this can get moved to 4.0

[celloexpressions]

Live-update the menu item handle title when the corresponding navigation label field is changed.

[celloexpressions]

I implemented something similar to this for menu names in my Menu Customizer project. This is a nice improvement and helps reinforce the relationship between the navigation label field and the item.

[wonderboymusic]

23076.2.diff​ deals with some JSHint and also uses delegation so the items don't have to already be on the page on load.

[wonderboymusic]

In 28707:

Live update the menu item title when the user is editing the "Navigation Label" field.

Props celloexpressions.
See #23076.

[wonderboymusic]

Leaving open in case someone has an opinion about the translation stuff.

[DrewAPicture]

hawt.

[wonderboymusic]

Fixed in [28789].

[nacin]

I'm concerned about the performance of [28707]:

• This is a huge DOM and we're letting every input event bubble all the way up to the body. Not good.

• The 'input' event is buggy in IE9 and nonexistent before then.

Can we also double-check this doesn't allow for self-XSS?

[celloexpressions]

We should be able to change $( 'body' ).on() to $( '#menu-to-edit' ).on() to help with performance (that's the direct parent of each menu item).

I wouldn't be worried if this doesn't work in old IE, since they'd just have the same situation as 3.9, but does it break things?

I have no idea about security implications here.

[helen]

23076.3.diff​ reels in the bubbling to #menu-to-edit and adds propertychange to the events - we do this elsewhere for IE < 9. Self-XSS is not an issue here, due to the use of .text().

[helen]

Further testing in IE8 and 9 indicates that propertychange and selectionchange, which I added for IE9's deletion issues in testing, are not firing at all. I haven't unraveled what's going on.

I'm comfortable just saying it doesn't work in IE8, but it's a little weird that it works except for deleting in IE9.

[nacin]

This was an enhancement and I'm most concerned about any performance regressions versus getting it to work in IE. 23076.3.diff​ is fine. We could remove 'propertychange' if it's confirmed it doesn't work in IE.

[nacin]

Fine to be committed.

[SergeyBiryukov]

Adding propertychange seems to cause ~90 second delays for me when editing menu items in IE8.

I'd suggest adding change instead: 23076.4.diff​.

[ocean90]

In 29672:

Menus: Improve performance for title live updating. Add change event for IE < 9.

props helen, SergeyBiryukov.
fixes #23076.