WordPress.org

Make WordPress Core

Opened 16 months ago

Closed 8 months ago

Last modified 8 months ago

#23091 closed enhancement (wontfix)

Need to remove deprecated get_bloginfo('url') from _fix_attachment_links() function

Reported by: hexalys Owned by:
Milestone: Priority: normal
Severity: normal Version: 3.5
Component: Administration Keywords: has-patch
Focuses: Cc:

Description

get_bloginfo('url'); is deprecated.
Should be home_url();

Attachments (2)

23091.diff (520 bytes) - added by MikeHansenMe 15 months ago.
23091.2.diff (1009 bytes) - added by SergeyBiryukov 15 months ago.

Download all attachments as: .zip

Change History (9)

comment:1 alexvorn216 months ago

from where? a old theme?

Version 0, edited 16 months ago by alexvorn2 (next)

MikeHansenMe15 months ago

comment:2 MikeHansenMe15 months ago

  • Cc mdhansen@… added
  • Keywords has-patch needs-testing added; needs-patch removed

comment:3 alexvorn215 months ago

  • Keywords needs-testing removed

SergeyBiryukov15 months ago

comment:4 SergeyBiryukov15 months ago

  • Component changed from Warnings/Notices to Administration
  • Keywords close added
  • Type changed from defect (bug) to enhancement

23091.2.diff also renames $site_url to $home_url, to prevent confusion.

However, get_bloginfo( 'url' ) is not deprecated, only home and siteurl parameters are:
http://core.trac.wordpress.org/browser/tags/3.5.1/wp-includes/general-template.php#L407

url is still a valid parameter. We use get_bloginfo( 'url' ) in some other places as well.

comment:5 MikeHansenMe15 months ago

This is confusing in the codex as it states 'home' is deprecated but 'url' is on the same line. Then states consider using home_url() instead. I think the patch is still an improvement as get_bloginfo( 'url' ) returns home_url() anyway. Seems removing a step is good and could be done other places in core as well.

comment:6 c3mdigital8 months ago

  • Keywords close removed
  • Resolution set to wontfix
  • Status changed from new to closed
if ( get_bloginfo( 'url' ) == home_url() )
      $ticket = 'wontfix';

get_bloginfo('url') is not deprecated and returns home_url(). No reason to change internally.

comment:7 SergeyBiryukov8 months ago

  • Milestone Awaiting Review deleted
Note: See TracTickets for help on using tickets.