#23101 closed defect (bug) (fixed)
RTL on visual editor
Reported by: | ramiy | Owned by: | nacin |
---|---|---|---|
Milestone: | 3.5.1 | Priority: | normal |
Severity: | normal | Version: | 3.5 |
Component: | RTL | Keywords: | has-patch commit |
Focuses: | Cc: |
Description
check out the screenshot.
Attachments (4)
Change History (13)
#3
in reply to:
↑ 1
@
12 years ago
Replying to SergeyBiryukov:
Looks better in 3.4
Sergey, they both look bad from user experience perspective. The dropdown should be wider and higher.
#4
@
12 years ago
- Keywords has-patch added; needs-patch removed
I think the only thing we can do for 3.5.1 is move the scrollbar back over and remove that lame -14px margin thing that I assume was a hack to make it look like it was aligned to the right side, which only worked with that dropdown with only default items: 23101.diff
It'll align with the left side of the toolbar item, and the selection icon is on the left, but I don't know what we can do about that positioning - it's all set by TinyMCE and there are no RTL icons. Maybe can investigate further in 3.6, but for 3.5.1 I'm not sure we can/should do too much more.
ramiy - can you explain what you mean by the dropdown being higher? And also, in your screenshot, could you explain what the arrow on the left is for? Screenshots are helpful, but please try to be descriptive with words where you can.
#5
@
12 years ago
- Keywords commit added
If 23101.diff restores things to the 3.4 screenshot (attachment:format-dropdown-wp34.png), I'm quite happy for this for 3.5.1.
#6
@
12 years ago
Right, yes, screenshots. It does, although it will be aligned to the left side of the box rather than seemingly-randomly 14 pixels over. We can restore that, but it's pretty meaningless. Image shows the default Format picker on the left, with added dropdowns and font size picker showing on the right.
We should probably figure out whether or not we can make TinyMCE behave better for RTL in 3.6. I have a suspicion it's not us.
Confirmed. Looks better in 3.4: format-dropdown-wp34.png.
I would expect the dropdowns in RTL to be right-aligned with the arrow though.