WordPress.org

Make WordPress Core

Opened 16 months ago

Closed 16 months ago

Last modified 16 months ago

#23101 closed defect (bug) (fixed)

RTL on visual editor

Reported by: ramiy Owned by: nacin
Milestone: 3.5.1 Priority: normal
Severity: normal Version: 3.5
Component: RTL Keywords: has-patch commit
Focuses: Cc:

Description

check out the screenshot.

Attachments (4)

visual-editor-rtl.png (86.9 KB) - added by ramiy 16 months ago.
format-dropdown-wp34.png (13.1 KB) - added by SergeyBiryukov 16 months ago.
23101.diff (346 bytes) - added by helen 16 months ago.
rtl-tinymce-dropdowns.png (16.4 KB) - added by helen 16 months ago.

Download all attachments as: .zip

Change History (13)

ramiy16 months ago

comment:1 follow-up: SergeyBiryukov16 months ago

Confirmed. Looks better in 3.4: format-dropdown-wp34.png.

I would expect the dropdowns in RTL to be right-aligned with the arrow though.

comment:2 SergeyBiryukov16 months ago

  • Milestone changed from Awaiting Review to 3.5.1

comment:3 in reply to: ↑ 1 ramiy16 months ago

Replying to SergeyBiryukov:

Looks better in 3.4

Sergey, they both look bad from user experience perspective. The dropdown should be wider and higher.

helen16 months ago

comment:4 helen16 months ago

  • Keywords has-patch added; needs-patch removed

I think the only thing we can do for 3.5.1 is move the scrollbar back over and remove that lame -14px margin thing that I assume was a hack to make it look like it was aligned to the right side, which only worked with that dropdown with only default items: 23101.diff

It'll align with the left side of the toolbar item, and the selection icon is on the left, but I don't know what we can do about that positioning - it's all set by TinyMCE and there are no RTL icons. Maybe can investigate further in 3.6, but for 3.5.1 I'm not sure we can/should do too much more.

ramiy - can you explain what you mean by the dropdown being higher? And also, in your screenshot, could you explain what the arrow on the left is for? Screenshots are helpful, but please try to be descriptive with words where you can.

comment:5 nacin16 months ago

  • Keywords commit added

If 23101.diff restores things to the 3.4 screenshot (attachment:format-dropdown-wp34.png), I'm quite happy for this for 3.5.1.

comment:6 helen16 months ago

Right, yes, screenshots. It does, although it will be aligned to the left side of the box rather than seemingly-randomly 14 pixels over. We can restore that, but it's pretty meaningless. Image shows the default Format picker on the left, with added dropdowns and font size picker showing on the right.

http://core.trac.wordpress.org/raw-attachment/ticket/23101/rtl-tinymce-dropdowns.png

We should probably figure out whether or not we can make TinyMCE behave better for RTL in 3.6. I have a suspicion it's not us.

comment:7 nacin16 months ago

In 23275:

Restore TinyMCE dropdowns to their 3.4 appearance in RTL. props helen. see #23101.

comment:8 nacin16 months ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 23276:

Restore TinyMCE dropdowns to their 3.4 appearance in RTL.

Merges [23275] to the 3.5 branch.
props helen.
fixes #23101.

comment:9 nacin16 months ago

Let's do a new ticket for improving the styles and working with TinyMCE upstream (as necessary). Considering this ticket fixed, as the regression is handled.

Note: See TracTickets for help on using tickets.