WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#23104 closed defect (bug) (fixed)

symlinks in DOCUMENT_ROOT result in bad output for mutltisite htaccess generation

Reported by: wpewill Owned by: markjaquith
Milestone: 3.5.1 Priority: normal
Severity: normal Version: 3.5
Component: Multisite Keywords: has-patch
Focuses: Cc:

Description

If there is a symlink somewhere in DOCUMENT_ROOT, it will differ from ABSPATH, causing the preg_replace prefix removal to fail, making the relative path calculation fail, resulting in a path from the filesystem root, except with the leading / missing

Attachments (1)

docroot-not-absolute.diff (849 bytes) - added by wpewill 3 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 @SergeyBiryukov3 years ago

  • Component changed from Network Admin to Multisite

comment:3 @evansolomon3 years ago

Looks reasonable to me.

comment:4 @markjaquith3 years ago

  • Milestone changed from Awaiting Review to 3.5.1

This is going into 3.5.1 along with #23073

comment:5 @markjaquith3 years ago

  • Owner set to markjaquith
  • Resolution set to fixed
  • Status changed from new to closed

In 23295:

Resolve DOCUMENT_ROOT symlinks and standardize Windows slashing for various paths related to Multisite rewrite rule generation. props SergeyBiryukov, nacin, wpewill. fixes #23104 and #23073 for trunk

comment:6 @markjaquith3 years ago

In 23296:

Resolve DOCUMENT_ROOT symlinks and standardize Windows slashing for various paths related to Multisite rewrite rule generation. props SergeyBiryukov, nacin, wpewill. fixes #23104 and #23073 for 3.5

Note: See TracTickets for help on using tickets.