Remove spaces between parentheses in function calls without arguments

[evansolomon]

I noticed there were a few spots with weird spaces in function calls. So it would like like foo( ) instead of foo(). It looks weird, so let's kill them off.

Here's what I ran to fix them: ack "\( \)" --ignore-dir=wp-content -l | xargs perl -pi -E 's/\( \)/\(\)/g'

[westi]

It could be argued that our coding style recommends the presence of these.

However, I agree that they do look weird - although I make no promises not to accidentally add more of them in future ;)

[evansolomon]

Replying to westi:

It could be argued that our coding style recommends the presence of these.

I imagine such a coding standard would quickly top the list of least-followed rules in WordPress.

Just for fun...

$ ack "\(\)" --php -h | wc -l
   10637

[nacin]

I like spaces. But I dislike them in two places: inside array brackets when the index is a static string (so, $foo['bar']), and here. Core overwhelmingly agrees. I searched for function definitions ending with () { and found 1290 matches.

Ending with ( ) { — 11.

And six of those were totally westi in default-constants.php. :)

[westi]

In 23265:

Tighten our braces. Fixes #23118 props evansolomon.

[westi]

Replying to evansolomon:

Replying to westi:

It could be argued that our coding style recommends the presence of these.

I imagine such a coding standard would quickly top the list of least-followed rules in WordPress.

Coding standards are always guides not rules.

[SergeyBiryukov]

Replying to westi:

It could be argued that our coding style recommends the presence of these.

I guess the space usage rule from our coding standards only applies if the function has arguments.