Opened 12 years ago
Closed 12 years ago
#23152 closed defect (bug) (fixed)
Twenty Twelve: Excessive CSS classes in functions.php
Reported by: | TomasM | Owned by: | lancewillett |
---|---|---|---|
Milestone: | 3.6 | Priority: | normal |
Severity: | normal | Version: | 3.5 |
Component: | Bundled Theme | Keywords: | has-patch |
Focuses: | Cc: |
Description (last modified by )
There is navigation part in twentytwelve_content_nav function:
<nav id="<?php echo $html_id; ?>" class="navigation" role="navigation"> <h3 class="assistive-text"><?php _e( 'Post navigation', 'twentytwelve' ); ?></h3> <div class="nav-previous alignleft"><?php next_posts_link( __( '<span class="meta-nav">←</span> Older posts', 'twentytwelve' ) ); ?></div> <div class="nav-next alignright"><?php previous_posts_link( __( 'Newer posts <span class="meta-nav">→</span>', 'twentytwelve' ) ); ?></div> </nav><!-- #<?php echo $html_id; ?> .navigation -->
We do not need CSS classes .alignleft and .alignright here, because the .nav-previous and .nav-next already have float properties in style.css. In one case this made the links appear in different lines while constructing the child theme. Although it didn't affect vanilla Twenty Twelve. The code could be just:
<nav id="<?php echo $html_id; ?>" class="navigation" role="navigation"> <h3 class="assistive-text"><?php _e( 'Post navigation', 'twentytwelve' ); ?></h3> <div class="nav-previous"><?php next_posts_link( __( '<span class="meta-nav">←</span> Older posts', 'twentytwelve' ) ); ?></div> <div class="nav-next"><?php previous_posts_link( __( 'Newer posts <span class="meta-nav">→</span>', 'twentytwelve' ) ); ?></div> </nav><!-- #<?php echo $html_id; ?> .navigation -->
Attachments (2)
Change History (10)
#3
follow-up:
↓ 4
@
12 years ago
Funny, but I don't know how to make a patch. I'm not using any version control software - using Trac only via browser interface. Can I submit patch via browser?
#4
in reply to:
↑ 3
@
12 years ago
Replying to TomasM:
Funny, but I don't know how to make a patch. I'm not using any version control software - using Trac only via browser interface. Can I submit patch via browser?
Take a peek at Submitting a Patch in the core handbook and see if that's something you're up for. If not, don't sweat it, one of us can take care of it.
Seems sensible. As
nav-previous
andnav-next
are already applied to this div element, addingalignleft
andalignright
are redundant.Plus, the RTL stylesheet already switches the floats on
nav-previous
andnav-next
.@TomasM: Would you like to make a patch?