WordPress.org

Make WordPress Core

Opened 16 months ago

Last modified 14 months ago

#23152 closed defect (bug)

Twenty Twelve: Excessive CSS classes in functions.php — at Initial Version

Reported by: TomasM Owned by:
Milestone: 3.6 Priority: normal
Severity: normal Version: 3.5
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

There is navigation part in twentytwelve_content_nav function:

		<nav id="<?php echo $html_id; ?>" class="navigation" role="navigation">
			<h3 class="assistive-text"><?php _e( 'Post navigation', 'twentytwelve' ); ?></h3>
			<div class="nav-previous alignleft"><?php next_posts_link( __( '<span class="meta-nav">&larr;</span> Older posts', 'twentytwelve' ) ); ?></div>
			<div class="nav-next alignright"><?php previous_posts_link( __( 'Newer posts <span class="meta-nav">&rarr;</span>', 'twentytwelve' ) ); ?></div>
		</nav><!-- #<?php echo $html_id; ?> .navigation -->

We do not need CSS classes .alignleft and .alignright here, because the .nav-previous and .nav-next already have float properties in style.css. In one case this made the links appear in different lines while constructing the child theme. Although it didn't affect vanilla Twenty Twelve. The code could be just:

		<nav id="<?php echo $html_id; ?>" class="navigation" role="navigation">
			<h3 class="assistive-text"><?php _e( 'Post navigation', 'twentytwelve' ); ?></h3>
			<div class="nav-previous"><?php next_posts_link( __( '<span class="meta-nav">&larr;</span> Older posts', 'twentytwelve' ) ); ?></div>
			<div class="nav-next"><?php previous_posts_link( __( 'Newer posts <span class="meta-nav">&rarr;</span>', 'twentytwelve' ) ); ?></div>
		</nav><!-- #<?php echo $html_id; ?> .navigation -->

Change History (1)

TomasM16 months ago

Note: See TracTickets for help on using tickets.