Make WordPress Core

Opened 8 years ago

Closed 7 years ago

#23155 closed defect (bug) (fixed)

Fire update_blog_public action from update_blog_status()

Reported by: ryan Owned by: ryan
Milestone: 3.6 Priority: normal
Severity: normal Version: 3.5
Component: Administration Keywords:
Focuses: Cc:

Description (last modified by SergeyBiryukov)

The update_blog_public action is fired from update_blog_public() but not from update_blog_status(). Since update_blog_public() calls update_blog_status() the action should move down the stack and reside along the other actions fired by update_blog_status().

Attachments (1)

23155.diff (1.9 KB) - added by ryan 8 years ago.

Download all attachments as: .zip

Change History (8)

8 years ago

#1 @ryan
8 years ago

I threw in some changes to noindex() that we run on wordpress.com. It repairs mismatches between the blog option and the site/network option. There's possibly a better place for this.

#2 @ryan
8 years ago

  • Milestone changed from Awaiting Review to 3.6

#3 @ryan
8 years ago

  • Owner set to ryan
  • Resolution set to fixed
  • Status changed from new to closed

In 23794:

Fire the update_blog_public action from update_blog_status() instead of update_blog_public(). Pass blog ID and value to the action.

Add code to noindex() to sync the 'public' value in the site options table with the blog_public value in the options table.

fixes #23155

#5 @SergeyBiryukov
8 years ago

  • Description modified (diff)

#6 @westi
7 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

I'm not convinced the code we added to noindex() is a good idea.

It is now possible that front end request(s) will cause writes to wp_blogs and invalidation of the blog details cache which seems like a bad idea.

Was there an issue you were trying to fix by adding this "syncing" on multisite?

Maybe we should move the syncing to something like admin_init instead?

#7 @ryan
7 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 24559:

Don't sync the blog public option from noindex(). This can cause race conditions.

fixes #23155

Note: See TracTickets for help on using tickets.