Fire update_blog_public action from update_blog_status()

[ryan]

The update_blog_public action is fired from update_blog_public() but not from update_blog_status(). Since update_blog_public() calls update_blog_status() the action should move down the stack and reside along the other actions fired by update_blog_status().

[ryan]

I threw in some changes to noindex() that we run on wordpress.com. It repairs mismatches between the blog option and the site/network option. There's possibly a better place for this.

[ryan]

In 23794:

Fire the update_blog_public action from update_blog_status() instead of update_blog_public(). Pass blog ID and value to the action.

Add code to noindex() to sync the 'public' value in the site options table with the blog_public value in the options table.

fixes #23155

[ryan]

​[UT1249]

[westi]

I'm not convinced the code we added to noindex() is a good idea.

It is now possible that front end request(s) will cause writes to wp_blogs and invalidation of the blog details cache which seems like a bad idea.

Was there an issue you were trying to fix by adding this "syncing" on multisite?

Maybe we should move the syncing to something like admin_init instead?

[ryan]

In 24559:

Don't sync the blog public option from noindex(). This can cause race conditions.

fixes #23155