WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#23164 closed defect (bug) (fixed)

Theme update screenshot are squished.

Reported by: cochran Owned by: helen
Milestone: 3.6 Priority: normal
Severity: minor Version:
Component: Administration Keywords: has-patch ui-feedback commit
Focuses: ui Cc:

Description

In the update admin screen the theme screenshots are squished to 64px square. Too keep with the 4:3 aspect ratio of theme screenshots the image width should be 85px so no distortion to the image occurs.

Attachments (1)

update-core.diff (1.1 KB) - added by cochran 3 years ago.
increases screenshot width to 85px wide to keep with aspect ratio of theme screenshots.

Download all attachments as: .zip

Change History (7)

@cochran3 years ago

increases screenshot width to 85px wide to keep with aspect ratio of theme screenshots.

comment:1 @SergeyBiryukov3 years ago

  • Component changed from Appearance to Administration
  • Keywords ui-focus added; 2nd-opinion removed

comment:3 @nacin3 years ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 3.6

comment:4 @helen3 years ago

  • Owner set to helen
  • Resolution set to fixed
  • Status changed from new to closed

In 23381:

Maintain theme screenshot aspect ratio on the update screen. props cochran. fixes #23164.

comment:5 @markoheijnen3 years ago

Isn't it possible to remove height or width? Will make it future proof then right.

comment:6 @helen3 years ago

Theme authors have a recommended screenshot size/aspect ratio but not all themes adhere to it, notably older ones. Those are going to get distorted a bit here, but not as badly as before. Otherwise, in order to maintain width and height in the layout (which is the desired effect), we'd have to add a wrapping container and CSS, like we do on Manage/Install Themes.

Note: See TracTickets for help on using tickets.