Make get_home_path() return consistent slashes

[SergeyBiryukov]

As noted in ticket:23073:40, get_home_path() doesn't return consistent slashes.

If home and siteurl are identical, it falls back to ABSPATH:

C:\wamp\www\multitest/

If home and siteurl are different:

C:/wamp/www/wordpress/test_subd/ 

[SergeyBiryukov]

I've reviewed all the instances of get_home_path() in core to make sure both types of slashes are allowed there (since it currently returns both types anyway).

It's mostly used in file_exists() and win_is_writable() checks, which is fine.

[SergeyBiryukov]

In 23669:

Make get_home_path() return consistent slashes. fixes #23175.

[bananastalktome]

Breaks unit test test_get_home_path in tests/admin/includesFile.php​

1) Tests_Admin_includesFile::test_get_home_path
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'D:\root\vhosts\site\httpdocs/'
+'D:/root/vhosts/site/httpdocs/'

(I'm reopening the ticket because of this, which I think is the proper thing to do in these cases. Please let me know if this is not what I should do.)

[SergeyBiryukov]

In 1244/tests:

Update get_home_path() test to reflect the change in [WP23669]. see #23175.

[SergeyBiryukov]

Replying to bananastalktome:

I'm reopening the ticket because of this, which I think is the proper thing to do in these cases.

It is, thanks.

[Marventus]

Fixes slash inconsistencies in ABSPATH constant

[Marventus]

Could this have come from the various

define('ABSPATH', dirname(__FILE__).'/');

commands scaretted accross multiple files? I took the liberty of creating a diff.

[SergeyBiryukov]

Yes, the trailing slash in ABSPATH is inconsistent in Windows, but it's out of scope for this ticket, and it's not really an issue, since Windows allows to use both types of slashes.

23175.3.patch​ would make the slashes inconsistent on non-Windows installs.

[Marventus]

it's not really an issue, since Windows allows to use both types of slashes

Well, it could be if you are doing path string comparisons. What if we used DIRECTORY_SEPARATOR instead?

define('ABSPATH', dirname(__FILE__).DIRECTORY_SEPARATOR);

Would that address non-Windows OSs?

it's out of scope for this ticket

If you agree with the above, should I create a new ticket and update the diff?
Thanks!

[SergeyBiryukov]

I'd suggest to normalize the slashes with str_replace( '\\', '/', ... ) before doing any string manipulations. This is what the core does in a few functions.

Using DIRECTORY_SEPARATOR was previously discussed in #15598, #17494, #20849, and #22267. The consensus in each ticket was that it's not needed.

[Marventus]

Ok, no worries, and thanks for the detailed answer!