WordPress.org

Make WordPress Core

Opened 15 months ago

Last modified 11 months ago

#23175 closed enhancement

Make get_home_path() return consistent slashes — at Version 2

Reported by: SergeyBiryukov Owned by:
Milestone: 3.6 Priority: normal
Severity: normal Version:
Component: Filesystem API Keywords: has-patch
Focuses: Cc:

Description (last modified by SergeyBiryukov)

As noted in ticket:23073:40, get_home_path() doesn't return consistent slashes.

If home and siteurl are identical, it falls back to ABSPATH:

C:\wamp\www\multitest/

If home and siteurl are different:

C:/wamp/www/wordpress/test_subd/ 

Change History (4)

SergeyBiryukov15 months ago

comment:1 SergeyBiryukov15 months ago

I've reviewed all the instances of get_home_path() in core to make sure both types of slashes are allowed there (since it currently returns both types anyway).

It's mostly used in file_exists() and win_is_writable() checks, which is fine.

Last edited 15 months ago by SergeyBiryukov (previous) (diff)

comment:2 SergeyBiryukov14 months ago

  • Description modified (diff)

SergeyBiryukov14 months ago

Note: See TracTickets for help on using tickets.