#23176 closed defect (bug) (fixed)
Inserting media with multiple newlines in caption breaks HTML
Reported by: | jonieske | Owned by: | azaozz |
---|---|---|---|
Milestone: | 3.5.1 | Priority: | normal |
Severity: | minor | Version: | 3.5 |
Component: | Media | Keywords: | has-patch |
Focuses: | Cc: |
Description
Steps to reproduce:
- Open add media dialog in editor to insert image
- Select image, enter caption with multiple newlines, eg:
"one
two
three"
- Leave alt text field empty
- Insert image into post
- Save/Update
As a result, HTML code breaks and image isn't displayed. This happens because caption is inserted to alt attribute in case it's empty, and newlines break the markup. Toggling between text and visual modes before initial post save fixes the code though.
Proposed fix:
Remove newlines from content that is automatically inserted to alt attribute.
Attachments (2)
Change History (8)
#2
follow-up:
↓ 3
@
12 years ago
- Keywords has-patch added; needs-patch removed
- Milestone changed from Awaiting Review to 3.5.1
Confirmed. Appears to be a regression. In 3.4.2, an empty alt attribute wasn't populated with caption, and remained empty after following the steps from the description.
#3
in reply to:
↑ 2
;
follow-up:
↓ 4
@
12 years ago
Replying to SergeyBiryukov:
Confirmed too. Perhaps the regex should be:
props.alt.replace( /[\r\n]+/g, ' ' );
so we replace multiple new lines with one space.
Note: See
TracTickets for help on using
tickets.
I can reproduce this against trunk. Here's the HTML code that gets generated when inserting the image with a multi-line caption and no alt tag: http://cl.ly/image/3c0d253C3O3a