Clear Notice from reset_header_image() method in Custom_Image_Header class

[wpsmith]

If you take the following steps you will receive a notice for default_data.

1. Custom header is enabled with a default header image (with no other header images uploaded).
2. The user clicks Remove Header Image.
3. The user clicks Restore Original Header Image.

[obenland]

I could not recreate it in latest trunk with the steps outlined above.

[wpsmith]

If you add the following to TwentyTwelve, it produces the same error.

add_theme_support(
	'custom-header', 
	array(
		'default-image'       => 'http://domain.com/wp-content/themes/twentytwelve/images/header.png', //Ensure image is there
		'header-text'         => '',
		'default-text-color'  => 'blank',
		'width'               => 350,
		'height'              => 100,
		'random-default'      => false,
	)
);

Here's a screencast:
​http://screencast.com/t/T0fTxyCZbH8G

Please note while the video demonstrates it with a Genesis Child theme image, this was tested in both Genesis, TwentyEleven, and TwentyTwelve.

[SergeyBiryukov]

Confirmed with the code from comment:2.

23181.2.patch​ is an alternative patch.

[kovshenin]

23181.patch​ can potentially leave old header image data in the header_image_data theme mod. If we're checking with !empty perhaps we should remove_theme_mod otherwise. 23181.2.patch looks reasonable, since it overwrites the previous value with an empty object.

[SergeyBiryukov]

In 23337:

Define the variable before using it. fixes #23181.