![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
Opened 14 years ago
Closed 13 years ago
#23184 closed enhancement (wontfix)
Twenty Eleven/Twelve: Mismatched lines in GitHub Gists
| Reported by: | obenland | Owned by: | |
|---|---|---|---|
| Priority: | lowest | Milestone: | |
| Component: | Bundled Theme | Version: | 3.5 |
| Severity: | normal | Keywords: | |
| Cc: | Focuses: |
Description
GitHub Gists are displayed with the code and line numbers misaligned, due to the difference in font-size and/or line-height of <pre> and <table> elements.
Originally reported in this thread and on wp.com.
Attachments (1)
Change History (12)
#2
in reply to: ↑ 1
@
14 years ago
- Cc added
23184.diff looks sane to me and I like it a lot better than all-out usurping the <pre> styles.
Replying to lancewillett:
So, while I'd love to fix this, I'd vote that this specific of a fix should be in the plugin itself, not in the default theme stylesheet.
Are you talking about upstream?
#3
in reply to: ↑ 1
@
14 years ago
Replying to lancewillett:
So, while I'd love to fix this, I'd vote that this specific of a fix should be in the plugin itself, not in the default theme stylesheet.
I'm confused. I thought your example Gist test on themebuster is using the JavaScript embed provided by GitHub, no?
#4
@
14 years ago
I can reproduce it in a local test with the javascript method.
Admitted, it is a prettic specific fix. While we provide custom code for third party services like Twitter and Jetpack, it could be argued that those are more likely to be tied in, than a Gist.
#5
@
13 years ago
- Keywords close added
- Milestone Awaiting Review → 3.6
Marking as "close" based on looking at the original thread: http://wordpress.org/support/topic/gists-look-crazy-with-twenty-twelve -- and looking at the URLs, the layout looks fixed in the plugin now.
#6
follow-up:
↓ 7
@
13 years ago
I think we should ping Github team and ask them to update the embedded CSS to account for line-height and font-size. That way instead of just patching this one theme -- it'll work great everywhere.
#7
in reply to: ↑ 6
@
13 years ago
Replying to lancewillett:
I think we should ping Github team and ask them to update the embedded CSS to account for line-height and font-size. That way instead of just patching this one theme -- it'll work great everywhere.
+1
#10
@
13 years ago
This really shouldn't be an issue of manually specifying a line height. It can be easily resolved with:
.gist pre {
font: inherit;
line-height: inherit;
white-space: pre;
}
(The white-space: pre is to resolve a twentythirteen issue, where the lines can wrap and then not match up with the numbers)
#11
@
13 years ago
- Keywords close removed
- Milestone WordPress.org
- Resolution → wontfix
- Status new → closed
Well, it looks like they followed georgestephanis' advice: https://gist.github.com/assets/embed-4252e560c3e6f4c476a216c2bb7938cd.css
So, while I'd love to fix this, I'd vote that this specific of a fix should be in the plugin itself, not in the default theme stylesheet.