WordPress.org

Make WordPress Core

Opened 8 years ago

Closed 8 years ago

#23189 closed defect (bug) (fixed)

Dots above Umlauts are not visible in title input field

Reported by: zodiac1978 Owned by: ocean90
Milestone: 3.6 Priority: normal
Severity: normal Version: 3.2
Component: Administration Keywords: has-patch commit
Focuses: ui Cc:

Description

If I have capital umlauts in a title ("ÜÖÄ") I don't see the dots above them in my title input field (see attachment).

FF 18 for Mac on Snow Leopard (Mac OS X 10.6.8)
In Safari 5.1.7 and Chrome 24 the bug is not there.

Maybe add some height/padding to the CSS like this:
#titlediv #title { height: 34px; padding: 5px 8px 0px 5px; }

Attachments (9)

Bildschirmfoto 2013-01-12 um 18.37.55.png (28.0 KB) - added by zodiac1978 8 years ago.
Firefox-Bug Input title field with umlauts
23189.patch (480 bytes) - added by ocean90 8 years ago.
23189.2.patch (480 bytes) - added by ocean90 8 years ago.
Refreshed
23189.3.patch (320 bytes) - added by lessbloat 8 years ago.
23189.diff (330 bytes) - added by helen 8 years ago.
23189.png (13.4 KB) - added by ocean90 8 years ago.
23189.4.diff​ (490 bytes) - added by lessbloat 8 years ago.
23189.4.diff (490 bytes) - added by lessbloat 8 years ago.
23189.5.patch (488 bytes) - added by ocean90 8 years ago.
Refreshed

Download all attachments as: .zip

Change History (17)

@zodiac1978
8 years ago

Firefox-Bug Input title field with umlauts

#1 @ocean90
8 years ago

  • Component changed from General to Administration
  • Keywords needs-patch ui-focus added
  • Milestone changed from Awaiting Review to 3.6
  • Version set to 3.2

@ocean90
8 years ago

#2 @ocean90
8 years ago

  • Keywords has-patch added; needs-patch removed

Firefox ignores the line-height because it declares line-height with normal !important. You can find this by opening jar:file:///Applications/Firefox.app/Contents/MacOS/omni.ja!/chrome/toolkit/res/forms.css in Firefox.

Since we are also using sans-serif, which is Helvetica on OS X and a bit bigger, the dots are now hidden.

Seems like the only solution is to set a height explicit. Done in 23189.patch.

@ocean90
8 years ago

Refreshed

@lessbloat
8 years ago

#3 follow-up: @lessbloat
8 years ago

Removed the vertical padding tweak in 23189.3.patch​, as it won't have any affect. Other than that, it looks good to me.

@helen
8 years ago

#4 @helen
8 years ago

We *really* need to stay away from pixel heights on things like inputs, please. 23189.diff seems to work for me.

@ocean90
8 years ago

#5 in reply to: ↑ 3 ; follow-up: @ocean90
8 years ago

Replying to lessbloat:

Removed the vertical padding tweak in 23189.3.patch​, as it won't have any affect. Other than that, it looks good to me.

The reason for the padding and why we should add it back:

http://core.trac.wordpress.org/raw-attachment/ticket/23189/23189.png

@lessbloat
8 years ago

#6 in reply to: ↑ 5 @lessbloat
8 years ago

Replying to ocean90:

The reason for the padding and why we should add it back:

http://core.trac.wordpress.org/raw-attachment/ticket/23189/23189.png

You're right. See 23189.4.diff.

@lessbloat
8 years ago

#7 @ocean90
8 years ago

  • Keywords commit added

@ocean90
8 years ago

Refreshed

#8 @ocean90
8 years ago

  • Owner set to ocean90
  • Resolution set to fixed
  • Status changed from new to closed

In 23976:

Set a height for post title input

Firefox ​ignores the line-height because it declares line-height with normal !important in one of it's browser stylesheets. This can result in missing dots above umlauts.

props helen, lessbloat.
fixes #23189

Note: See TracTickets for help on using tickets.