WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #23190, comment 4


Ignore:
Timestamp:
01/13/13 14:31:11 (18 months ago)
Author:
scribu
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #23190, comment 4

    initial v1  
    33> if there is no binding on wp_insert_user() with a numeric value (123456) as user-id then get_user_id_from_string() should also respect this choice and return 99 here instead of 123456 
    44 
    5 I don't think that's a good idea, unless we plan to support numeric user_logins everywhere. For example, `WP_User::__construct()` has the same heuristic. 
     5I don't think that's a good idea, unless we plan to support numeric `user_login`s everywhere. For example, `WP_User::__construct()` has the same heuristic. 
    66 
    77We should just document that `get_user_id_from_string( $x )` will return $x, if $x is numeric.