WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 2 of Ticket #23192


Ignore:
Timestamp:
01/13/2013 10:28:01 PM (12 years ago)
Author:
SergeyBiryukov
Comment:

I agree. We could then deprecate get_user_id_from_string(), since it's the only instance in core.

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #23192

    • Property Keywords has-patch added; 2nd-opinion removed
    • Property Milestone changed from Awaiting Review to 3.6

  • Ticket #23192 – Description

    initial v2  
    11Comes up after reading #23190.
    22
    3 Since `is_user_spammy` expects a user name, we should replace it with get_user_by( 'login', $username ). Same for the id.
     3Since `is_user_spammy` expects a user name, we should replace `get_user_id_from_string( $username )` with `get_user_by( 'login', $username )`. Same for the id.