Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#23194 closed enhancement (fixed)

Use disabled() in post_tags_meta_box() and wp_popular_terms_checklist()

Reported by: SergeyBiryukov Owned by: SergeyBiryukov
Milestone: 3.6 Priority: normal
Severity: normal Version:
Component: Administration Keywords: has-patch commit dev-reviewed
Focuses: Cc:


Both functions output 'disabled="disabled"' directly. We have a helper function for that.

Attachments (1)

23194.patch (3.6 KB) - added by SergeyBiryukov 3 years ago.

Download all attachments as: .zip

Change History (5)

@SergeyBiryukov3 years ago

comment:1 @SergeyBiryukov3 years ago

23194.patch also removes the esc_attr() call on separate_items_with_commas label, which seems erroneous. It was added along with the label in [15190]. Per ticket:19712:5, labels are considered safe.

Last edited 3 years ago by SergeyBiryukov (previous) (diff)

comment:2 @ocean903 years ago

  • Keywords commit added

comment:3 @nacin3 years ago

  • Keywords dev-reviewed added
  • Owner set to SergeyBiryukov
  • Status changed from new to assigned

comment:4 @SergeyBiryukov3 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 23352:

Consistently use a helper function instead of directly printing the disabled attribute.

Remove an erroneous esc_attr() call.

fixes #23194.

Note: See TracTickets for help on using tickets.