Context Navigation

← Previous Ticket
Next Ticket →

#23194 closed enhancement (fixed)

Use disabled() in post_tags_meta_box() and wp_popular_terms_checklist()

Reported by:	SergeyBiryukov	Owned by:	SergeyBiryukov
Priority:	normal	Milestone:	3.6
Component:	Administration	Version:
Severity:	normal	Keywords:	has-patch commit dev-reviewed
Cc:		Focuses:

Description

Both functions output 'disabled="disabled"' directly. We have a helper function for that.

Attachments (1)

23194.patch (3.6 KB ) - added by SergeyBiryukov 13 years ago.

Download all attachments as: .zip

Change History (5)

@SergeyBiryukov
13 years ago

Attachment 23194.patch added

#1 @SergeyBiryukov
13 years ago

23194.patch also removes the esc_attr() call on separate_items_with_commas label, which seems erroneous. It was added along with the label in [15190]. Per ticket:19712:5, labels are considered safe.

Last edited 13 years ago by SergeyBiryukov (previous) (diff)

#2 @ocean90
13 years ago

Keywords commit added

#3 @nacin
13 years ago

Keywords dev-reviewed added
Owner set to SergeyBiryukov
Status new → assigned

#4 @SergeyBiryukov
13 years ago

Resolution → fixed
Status assigned → closed

In 23352:

Consistently use a helper function instead of directly printing the disabled attribute.

Remove an erroneous esc_attr() call.

fixes #23194.

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core