WordPress.org

Make WordPress Core

Changes between Version 1 and Version 2 of Ticket #23216, comment 97


Ignore:
Timestamp:
07/17/2013 03:49:51 AM (6 years ago)
Author:
carldanley
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #23216, comment 97

    v1 v2  
    4848> Like the function names changes, not sure all functions in the private scope have to start with an underscore. Don't see this anywhere else in WordPress. Also not sure it needs all the new private functions. Maybe they make heartbeat a little bit slower after the patch.
    4949
    50 Prefixing with an underscore is a preference but I think it's a good one as it clearly denotes the use of private methods in this module. I can't speak for the rest of WordPress but I know that either way clear code is always better. As for performance, I highly doubt that there are any performance hits.
     50I feel that prefixing with an underscore is a great convention and try to promote it as a good way to clearly denote the use of private methods, but yes it is a preference.
     51
     52As I mentioned, I will send a revised version tomorrow and let you take a look through it. Hopefully you will find parts of it to be helpful. It is totally up to you which parts you decide to keep.