WordPress.org

Make WordPress Core

Changes between Version 2 and Version 3 of Ticket #23216, comment 97


Ignore:
Timestamp:
07/17/13 14:43:21 (9 months ago)
Author:
carldanley
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #23216, comment 97

    v2 v3  
    22> I would have really appreciated another pair of eyes on this couple of months ago, when heartbeat was in development. Restructuring/rewriting parts of it in RC seems too late. 
    33 
    4 I do apologize for not being available earlier. This was my first available time, and Nacin suggested that I look at this ticket. I hope you will find my revised contribution tomorrow morning to be helpful even at this late stage. I will be taking all of your comments into consideration as I prepare it. As the current implementation of this feature is still "experimental", I figured a second set of eyes wouldn't hurt. I know it's late in RC but I think there was room to make improvements in the existing iteration and prevent any security flaws without affecting the integrity of this feature. I fixed a few funky things and added "to do" notes for areas that need help in future iterations of WP. 
     4I do apologize for not being available earlier. This was my first available time, and Nacin suggested that I look at this ticket. I hope you will find my revised contribution tomorrow morning to be helpful even at this late stage. I will be taking all of your comments into consideration as I prepare it. 
    55  
    66> Currently the API is in "experimental" stage. The usefulness of the initial idea was severely reduced by concerns it will overwhelm shared hosting accounts because it connects every 15 seconds while a user is logged in. It is structured as a (pseudo) class so it can have private and public vars and methods, however that class is intended to be initialized only once and is not intended to be extendable.