![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
#23232 closed defect (bug) (fixed)
[E_STRICT] mo.php import_from_reader
| Reported by: | zenation | Owned by: | SergeyBiryukov |
|---|---|---|---|
| Priority: | normal | Milestone: | 3.6 |
| Component: | Warnings/Notices | Version: | 3.5 |
| Severity: | minor | Keywords: | has-patch commit |
| Cc: | Focuses: |
Description
I'm getting a STRICT error for /wp-includes/pomo/mo.php saying that only variables should be passed by reference. So my suggestion is to replace line 210 (function: import_from_reader)
$this->set_headers($this->make_headers($translation));
with these two lines
$translationHeaders = $this->make_headers( $translation ); $this->set_headers( $translationHeaders );
I'm looking @version $Id: mo.php 718 2012-10-31 00:32:02Z nbachiyski $
Attachments (2)
Change History (16)
#4
@
13 years ago
Go ahead and commit it, it's on my list to make sure the WordPress version of pomo is the canonical one.
#5
@
13 years ago
Actually, nikolay, I'm wondering why $headers is by reference. I think we could remove it, given that we're not doing anything to $headers (and likely never would want to).
#6
@
13 years ago
@nacin, we have a ton of references still from the old PHP4 days when objects were copied if not passed by reference. We probably don't need most of them.
#7
follow-up:
↓ 8
@
13 years ago
we did a lot of that here [21839] and then broke i18n as per Sergey
#8
in reply to: ↑ 7
@
13 years ago
Replying to wonderboymusic:
we did a lot of that here [21839] and then broke i18n as per Sergey
Did you really mean [21839]?
#10
@
13 years ago
Removing the reference (23232.2.patch) actually works too.
Fixed in [19072], reintroduced in [22349].