#23232 closed defect (bug) (fixed)
[E_STRICT] mo.php import_from_reader
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 3.6 | Priority: | normal |
Severity: | minor | Version: | 3.5 |
Component: | Warnings/Notices | Keywords: | has-patch commit |
Focuses: | Cc: |
Description
I'm getting a STRICT error for /wp-includes/pomo/mo.php saying that only variables should be passed by reference. So my suggestion is to replace line 210 (function: import_from_reader)
$this->set_headers($this->make_headers($translation));
with these two lines
$translationHeaders = $this->make_headers( $translation ); $this->set_headers( $translationHeaders );
I'm looking @version $Id: mo.php 718 2012-10-31 00:32:02Z nbachiyski $
Attachments (2)
Change History (16)
#1
@
11 years ago
- Component changed from General to Warnings/Notices
- Milestone changed from Awaiting Review to 3.6
#4
@
11 years ago
Go ahead and commit it, it's on my list to make sure the WordPress version of pomo is the canonical one.
#5
@
11 years ago
Actually, nikolay, I'm wondering why $headers is by reference. I think we could remove it, given that we're not doing anything to $headers (and likely never would want to).
#6
@
11 years ago
@nacin, we have a ton of references still from the old PHP4 days when objects were copied if not passed by reference. We probably don't need most of them.
#7
follow-up:
↓ 8
@
11 years ago
we did a lot of that here [21839] and then broke i18n as per Sergey
#8
in reply to:
↑ 7
@
11 years ago
Replying to wonderboymusic:
we did a lot of that here [21839] and then broke i18n as per Sergey
Did you really mean [21839]?
#10
@
11 years ago
Removing the reference (23232.2.patch) actually works too.
#11
@
11 years ago
This isn't a PHP4-style reference. It's taking an array of headers by reference, but then not changing said array, making the reference fairly useless. I'm fine with removing it. Would be good to see if blaming this gleans any light.
Fixed in [19072], reintroduced in [22349].