WordPress.org

Make WordPress Core

Opened 15 months ago

Last modified 11 months ago

#23247 new enhancement

Grammar Fix on setup when wp-config-sample.php does not exist

Reported by: bradparbs Owned by:
Milestone: Future Release Priority: normal
Severity: trivial Version:
Component: Text Changes Keywords: has-patch commit
Focuses: Cc:

Description (last modified by johnbillion)

Patch changes

Sorry, I need a wp-config-sample.php file to work from. Please re-upload this file from your WordPress installation.

to

Sorry, I need a wp-config-sample.php file to work from. Please re-upload this file to your WordPress installation.

Makes it a little more clear.
Perhaps in the future, we can remove the need for wp-config-sample.php all together.

Attachments (2)

23247.diff (624 bytes) - added by bradparbs 15 months ago.
fixes wp-admin/setup-config.php
23247.2.diff (652 bytes) - added by SergeyBiryukov 15 months ago.

Download all attachments as: .zip

Change History (13)

bradparbs15 months ago

fixes wp-admin/setup-config.php

comment:1 bradparbs15 months ago

  • Keywords has-patch added

comment:2 SergeyBiryukov15 months ago

  • Milestone changed from Awaiting Review to 3.6

comment:3 johnbillion15 months ago

  • Description modified (diff)

comment:4 SergeyBiryukov15 months ago

  • Keywords 2nd-opinion added

I always thought that "from your WordPress installation" means the actual .zip file here, so the sentence seems correct to me as is.

comment:5 DrewAPicture15 months ago

  • Keywords 2nd-opinion removed

'to' is better than 'from'. 'from' implies that your WordPress installation lives somewhere else.

Regardless, the whole sentence reads a little bit weird. I'd almost rather prefer something like this:

Please re-upload this file to your WordPress installation's root directory.

comment:6 DrewAPicture15 months ago

Or sans-possessive:

Please re-upload this file to the root directory of your WordPress installation.

SergeyBiryukov15 months ago

comment:7 SergeyBiryukov15 months ago

  • Keywords commit added

The latest suggestion sounds good to me.

comment:8 SergeyBiryukov14 months ago

  • Keywords commit removed

Nacin noted that "to the root directory" might be confusing too:
https://irclogs.wordpress.org/chanlog.php?channel=wordpress-dev&day=2013-01-31&sort=asc#m544072

comment:9 bradparbs13 months ago

What if we remove the 'root directory' part, but also add in something for everyone that just does 1-click installs?

Something like:

Please re-upload this file to your WordPress installation or contact your host.

comment:10 SergeyBiryukov13 months ago

  • Keywords commit added

I guess I'd prefer the original suggestion:

Please re-upload this file to your WordPress installation.

comment:11 ryan11 months ago

  • Milestone changed from 3.6 to Future Release
Note: See TracTickets for help on using tickets.