WordPress.org

Make WordPress Core

Opened 8 years ago

Closed 6 years ago

#23247 closed enhancement (fixed)

Grammar Fix on setup when wp-config-sample.php does not exist

Reported by: bradparbs Owned by: SergeyBiryukov
Milestone: 4.4 Priority: normal
Severity: trivial Version:
Component: Text Changes Keywords: has-patch
Focuses: Cc:

Description (last modified by johnbillion)

Patch changes

Sorry, I need a wp-config-sample.php file to work from. Please re-upload this file from your WordPress installation.

to

Sorry, I need a wp-config-sample.php file to work from. Please re-upload this file to your WordPress installation.

Makes it a little more clear.
Perhaps in the future, we can remove the need for wp-config-sample.php all together.

Attachments (2)

23247.diff (624 bytes) - added by bradparbs 8 years ago.
fixes wp-admin/setup-config.php
23247.2.diff (652 bytes) - added by SergeyBiryukov 8 years ago.

Download all attachments as: .zip

Change History (16)

@bradparbs
8 years ago

fixes wp-admin/setup-config.php

#1 @bradparbs
8 years ago

  • Keywords has-patch added

#2 @SergeyBiryukov
8 years ago

  • Milestone changed from Awaiting Review to 3.6

#3 @johnbillion
8 years ago

  • Description modified (diff)

#4 @SergeyBiryukov
8 years ago

  • Keywords 2nd-opinion added

I always thought that "from your WordPress installation" means the actual .zip file here, so the sentence seems correct to me as is.

#5 @DrewAPicture
8 years ago

  • Keywords 2nd-opinion removed

'to' is better than 'from'. 'from' implies that your WordPress installation lives somewhere else.

Regardless, the whole sentence reads a little bit weird. I'd almost rather prefer something like this:

Please re-upload this file to your WordPress installation's root directory.

#6 @DrewAPicture
8 years ago

Or sans-possessive:

Please re-upload this file to the root directory of your WordPress installation.

#7 @SergeyBiryukov
8 years ago

  • Keywords commit added

The latest suggestion sounds good to me.

#8 @SergeyBiryukov
8 years ago

  • Keywords commit removed

Nacin noted that "to the root directory" might be confusing too:
https://irclogs.wordpress.org/chanlog.php?channel=wordpress-dev&day=2013-01-31&sort=asc#m544072

#9 @bradparbs
8 years ago

What if we remove the 'root directory' part, but also add in something for everyone that just does 1-click installs?

Something like:

Please re-upload this file to your WordPress installation or contact your host.

#10 @SergeyBiryukov
8 years ago

  • Keywords commit added

I guess I'd prefer the original suggestion:

Please re-upload this file to your WordPress installation.

#11 @ryan
8 years ago

  • Milestone changed from 3.6 to Future Release

#12 @wonderboymusic
6 years ago

  • Keywords commit removed

#13 @wonderboymusic
6 years ago

  • Milestone changed from Future Release to 4.4
  • Owner set to SergeyBiryukov
  • Status changed from new to assigned

#14 @SergeyBiryukov
6 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 35143:

Correct the error message displayed on setup when wp-config-sample.php does not exist.

Props bradparbs.
Fixes #23247.

Note: See TracTickets for help on using tickets.