Make WordPress Core

Opened 15 months ago

Closed 7 months ago

Last modified 6 months ago

#23251 closed defect (bug) (fixed)

WordPress tries to unnecessarily set the memory limit

Reported by: peterjaap Owned by: nacin
Milestone: 3.7 Priority: normal
Severity: normal Version: 2.5
Component: General Keywords: has-patch 3.7-early
Focuses: Cc:

Description (last modified by SergeyBiryukov)

Fixed bug where WordPress tries to unnecessarily set the memory limit when a value like '2G' is used instead of '2048M'.

See bad code & good code over at Github, which is what you should be using for stuff like this; https://github.com/WordPress/WordPress/pull/26

Discovered by @willem_o and @PeterJaap

Attachments (1)

23251.patch (860 bytes) - added by faishal 13 months ago.

Download all attachments as: .zip

Change History (18)

comment:1 markoheijnen15 months ago

Please add a patch instead of a link to a pull request. Also related to this ticket is: #14889

comment:2 peterjaap15 months ago

Why was that submitted 2 YEARS AGO and still hasn't been fixed, while the patch is already there?

comment:3 peterjaap15 months ago

And please migrate to Github instead of using trac.

comment:4 helen15 months ago

#14889 is closed as fixed.

comment:5 markoheijnen15 months ago

I say related. If you read the comments you will noticed why it isn't done. Also saying stuff like migrate to Github without knowing anything about the current progress isn't really smart to do.

comment:6 SergeyBiryukov15 months ago

  • Version changed from trunk to 2.5

comment:7 peterjaap15 months ago

I've read the comments, can't see why the initial issue still isn't solved. It seems the commenters go off-topic with talk about benchmarking and the -1 option while all they should do is fix the bug and go from there. And it's marked as fixed, but its far from fixed.

comment:8 nacin15 months ago

  • Milestone changed from Awaiting Review to 3.6

Maybe I missed it then (and now, as I just re-read the ticket), but it seems that #14889 was primarily hung up on WP_MEMORY_LIMIT possibly being specified in G, rather than PHP's memory_limit core ini directive. You can shout in all caps but it isn't very respectful.

I'm fine with a patch along these lines. It would be good to determine exactly what values of memory_limit we should listen to. For example, it accounts for case insensitivity, which seems like a good idea. We have wp_convert_hr_to_bytes() in wp-includes/media.php — should we be moving that to wp-includes/load.php, improve it directly, and adapt it here?

While we don't accept pull requests via Github, you can simply add .diff or .patch to many GitHub URLs to get valid patches. For example: https://github.com/WordPress/WordPress/pull/26.diff. We also have no plans to migrate to GitHub, but that doesn't mean you can't use it to contribute — http://scribu.net/wordpress/contributing-to-wordpress-using-github.html.

comment:9 SergeyBiryukov15 months ago

  • Description modified (diff)
  • Summary changed from Fixed bug where Wordpress tries to unnecessarily set the memory limit to WordPress tries to unnecessarily set the memory limit

comment:10 SergeyBiryukov14 months ago

  • Keywords needs-patch added; has-patch removed

faishal13 months ago

comment:11 faishal13 months ago

  • Keywords has-patch added; needs-patch removed

comment:12 nacin10 months ago

  • Keywords 3.7-early added
  • Milestone changed from 3.6 to Future Release

Going to move this to 3.7. Thanks for the contributions.

comment:13 wonderboymusic9 months ago

  • Milestone changed from Future Release to 3.7

these are all marked 3.7-early

comment:14 nacin7 months ago

Per http://www.php.net/manual/en/faq.using.php#faq.using.shorthandbytes, only K, M, and G are allowed. Trying to account for T is kind of insane.

comment:15 nacin7 months ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 25684:

Don't override a PHP memory_limit specified using G shorthand.

props peterjaap.
fixes #23251.

comment:16 nacin7 months ago

In 25685:

Support G shorthand for WP_MEMORY_LIMIT. see #23251.

comment:17 ocean906 months ago

stripos() is new in PHP 5, means you get a fatal error on PHP 4 now.

Note: See TracTickets for help on using tickets.