WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #23275, comment 2


Ignore:
Timestamp:
01/24/13 16:03:16 (2 years ago)
Author:
WraithKenny
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #23275, comment 2

    initial v1  
    11The issue: 
    22 
    3 I've noticed that on some installs (xampp, mampp) the parsing of the import file into php, and then the attempt to unserialize fails do to line-ending mismatches. This patch attempts to normalize the line-endings if first pass fails, and adjusts the s-length if the second pass fails.  
     3I've noticed that on some installs (xampp, mampp, so basically all my local installs) the parsing of the import file into php, and then the attempt to unserialize fails do to line-ending mismatches. This patch attempts to normalize the line-endings if first pass fails, and adjusts the s-length if the second pass fails.  
    44 
    55Alternatively, finding out which step causes the line-endings to change/conflict and preventing it there might be a better/cleaner solution, but that might be with how plugins store meta_data. My own plugin seems to save different endings via html post or ajax save. It doesn't effect the functioning of the plugin tho, only the importing of the meta_data. This should be fine anyway, except that when the file is saved (either by the browser, or up to the server or when the file is processed), then line-endings change, corrupting data or the s:length.