Definition List in Editor

[gputignano]

After switch from Text to Visual and then from Visual to Text the formatting of the definition list is lost.

[ocean90]

Input:

<dl>
<dt>Foo</dt>
<dd>Bar Foo Bar</dd>
</dl>

Expected output:

<dl>
	<dt>Foo</dt>
	<dd>Bar Foo Bar</dd>
</dl>

Actual output:

<dl><dt>Foo</dt><dd>Bar Foo Bar</dd></dl>

---

The expected output comes from the output of an (un)ordered list. So we should be able to do the same for definition lists.

23299.patch​ adds just the new line for each element. Seems like the tab indention is handled in TinyMCE; azaozz, help?

[ocean90]

Replying to ocean90:

Seems like the tab indention is handled in TinyMCE; azaozz, help?

Strike that. Done in 23299.2.patch​.

[azaozz]

Strike that. Done in 23299.2.patch​.

Yep, HTML white space in the Text editor is controlled by pre_wpautop(). However the changes there are permanent, post_content is saved exactly as shown (whether the user switches to the Text editor or not) so any changes there will affect the PHP wpautop() and how the content is displayed on the front-end.

In this particular case nothing seems to break. Note that <dl> is not handled in TinyMCE by default, pasting <dl> in the Text editor and trying to edit it from the Visual editor won't work well. There is a TinyMCE plugin that handles it but it's not included by default.

[ocean90]

Related: #28939

[swissspidy]

Patch doesn't apply cleanly anymore as the wp-admin/js/editor.js has changed a bit over the year.

[katieburch]

Refreshed patch

[swissspidy]

Just tested 23299.diff​.

Input:

<dl>
<dt>Foo</dt>
<dd>Bar Foo Bar</dd>
</dl>

Actual output:

<dl>
	<dt>Foo</dt>
	<dd>Bar Foo Bar</dd>
</dl>

Conclusion: It works like a charm.

[swissspidy]

In 35999:

Editor: Correctly indent definition lists when switching from the visual to the text editor.

Props ocean90, katieburch.
Fixes #23299.