Opened 12 years ago
Closed 12 years ago
#23312 closed task (blessed) (fixed)
Post Lock Interface for Post List Screen
Reported by: | dh-shredder | Owned by: | |
---|---|---|---|
Milestone: | 3.6 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Autosave | Keywords: | autosave-redo has-patch |
Focuses: | Cc: |
Description
For 3.6, we'd like to improve the experience for users with post locks!
For the Post List screen, we'd like to:
- Make it easy for users to tell which posts are locked directly from the post list screen.
- Realtime lock update using Heartbeat API (#23216)
Maybe:
- Make it visible which user holds the lock
- Meta editing allowed while post is locked
Attachments (17)
Change History (44)
#1
@
12 years ago
Rough first pass for discussion.
Requires lock image in wp-admin/images/lock_16x16x32.png.
- Displays lock in lieu of checkbox if post is locked. This has the intended secondary effect of disabling bulk edit when a post is locked.
- Removes link to Quick Edit for any locked post.
#2
@
12 years ago
- Milestone changed from Awaiting Review to 3.6
- Type changed from enhancement to task (blessed)
#3
@
12 years ago
Extended 23312.diff a bit to use css class to show/hide the lock icon and show "Currently edited by.." under the post title as discussed with @dh-shredder. That would make it easier to (eventually) update which posts are locked dynamically.
#4
@
12 years ago
Looks good! The display is a little odd when only one row is a different height than the rest, but I really like the increased information available.
#5
@
12 years ago
here is a screenshot of the UI: http://cl.ly/image/3h0R261k1O2Z
#8
follow-up:
↓ 10
@
12 years ago
I've uploaded lock graphics in classic and flat styles; 16x16 and 32x32 versions for retina. Sorry no time to slice at the moment...
#9
@
12 years ago
Since we're not suppressing the creation of the checkboxes when locked, 23312.no_bulk_edit_hidden.diff keeps the hidden checkboxes from being checked, thus keeping them from being selected for bulk edit.
#10
in reply to:
↑ 8
@
12 years ago
Replying to empireoflight:
I've uploaded lock graphics in classic and flat styles; 16x16 and 32x32 versions for retina. Sorry no time to slice at the moment...
Thanks! Those look great.
#12
@
12 years ago
23312-4.patch fixes the removal of locks and escapes the user name when adding a lock.
#17
follow-up:
↓ 19
@
12 years ago
Perhaps we can optimize this a bit: merge inline-edit-post.js
and the new edit-post.js
. Both would need to work well when displaying CPTs.
#19
in reply to:
↑ 17
;
follow-up:
↓ 20
@
12 years ago
Replying to azaozz:
Perhaps we can optimize this a bit: merge
inline-edit-post.js
and the newedit-post.js
. Both would need to work well when displaying CPTs.
Yes, makes sense.
23312-6.patch: don't check the lock if the current user cannot edit the post.
This made me wonder, if the user can see the post in the list (even if they cannot edit it) what is the harm in seeing current user activity?
#20
in reply to:
↑ 19
@
12 years ago
This made me wonder, if the user can see the post in the list (even if they cannot edit it) what is the harm in seeing current user activity?
We were talking with @dh-shredder about that too. Maybe sites with a lot of authors and contributors wouldn't want editor and admin users activities to be visible to all, although don't think it's an "information leak".
#21
@
12 years ago
Forgot to add a comment last night. Two things!
- New sliced lock icons from @empireoflight's original PSDs (lock.2.png & lock-2x.png) added
- First pass lock_avatars.diff to add avatars to post list locks added. This currently does send the HTML for the avatar itself from get_avatar() through heartbeat. If we need to avoid that, can do so as well, although this method is significantly simpler.
You can see a screenshot with both attached above.
Edit: Right now, the avatar is sized to match the new revision sized ones, at 18x18. We can reduce to 16x16, if it's not important to match sizes there.
#22
@
12 years ago
In new_icon_css.diff, add CSS for new icon, realign, and add lines to handle 2x version. Note that for this to work, you'll need to add the above lock.2.png (as lock.png) and lock-2x.png to your wp-admin/images directory.
Temporary Lock Icon. Source: CC0: http://thenounproject.com/noun/lock/#icon-No9362