Featured Image able to be set before image processed

[bobbravo2]

Steps to reproduce:

• Click set featured image
• Upload new (larger) file
• Click set featured image before the image has been resized.

The media modal show a blank square upon reopening the dialog: ​http://cl.ly/image/2h3R30432J2u

In addition, the featured image interface breaks until the page is reloaded. To confirm, after seeing the blank media box as pictured, try setting the featured image again.

Tested on 3.6-alpha-23334 with WP_DEBUG && SCRIPT_DEBUG set to true

[nacin]

Is this reproducible in 3.5.0? I am guessing not.

[ew_holmes]

This is reproducible in 3.5.0-RC4. Selecting "Set featured image" before the image is processed/uploaded causes the Featured image modal to close, but the featured image is not set.

Upon re-opening the featured image selection, the original image is there, along with the blank square. It disappears when the page is refreshed.

[ew_holmes]

Screenshot of the result.

[kadamwhite]

If any attachments within the current selection have not finished uploading, then the submit button will fail in both the "Insert Media" frame and the "Set Featured Image" media frame. The extra ghost attachment item is just a side-effect of the weird state you get by trying to set the featured image when the attachment's data isn't available.

After speaking with Helen, we feel it makes sense to disable the submit button if any image within the current selection has not yet finished uploading. This will prevent the unexpected behavior of clicking the "insert" button and seeing no action, as well as preventing the creation of the empty extra Attachment model.

CrazyJaco & I have a patch for this, attached above. We are using _.map to get a list of the uploading state of all models within the collection, then identifying whether any of those uploads are still in progress with _.some.

[kadamwhite]

Re-uploaded the patch to remove the call to _.map, as it was completely unneeded -- you can call .get('uploading') from directly within _.some()

[kadamwhite]

Patch to prevent submission of media frame if any selected attachment is still uploading

[kadamwhite]

Just tested this against latest trunk—it merges cleanly and seems to still do its job.

[markjaquith]

In 23956:

Don't allow images to be set as featured image until they have been processed.

props kadamwhite. fixes #23317.

[kadamwhite]

Flipped operands of === per georgestephanis