The lookup in text editor does nothing when I enter text in hebrew

[mark-k]

1. In the text editor Click lookup
2. In the window enter hebrew text and submit
3. Window closes but nothing else happens

For english text a tab is opened with proper page from answers.com or a "can't find" page.

Several questions

1. What is the purpose of that button?
2. Why answers.com? It is hardcoded in JS
3. If this is useful, why there is no such button in the visual editor?

[dd32]

This appears to be some kind of Spell button in Quicktags: ​http://core.trac.wordpress.org/browser/trunk/wp-includes/js/quicktags.js#L502

I would assume that Hebew text doesn't pass as "word" characters in Javascript regular expressions causing nothing to happen.

I uh, vote to remove the button myself, it doesn't appear to be anything of use, When it was added 9 years ago, answers.com may have actually been useful.

For reference, answers.com was added in [2476] (previously it was dictionary.reference.com, which was either present in b2, or added somewhere around WordPress changeset [300]).

[mark-k]

+1 for removal, looks totally useless.

[nacin]

Have never noticed this.

[mboynes]

I agree, this is pretty useless. Sorry answers.com, no more free traffic for you.

I just added a patch that removes the button from the toolbar, but doesn't remove the functionality (in the event that someone uses it, this will allow them to add it back very easily). I moved the "close" button up in the array as well from key 140 to key 130.

[mboynes]

Removing lookup button from quicktags array

[jonbishop]

Do we want to leave the functionality in there? I feel like it's easy enough to add back in as a plugin and why leave something like that hidden in core.

Also, don't we need to remove 'spell' from the quicktag settings anywhere we manually call the editor?

[jonbishop]

This removes all references to 'spell' in quicktags args and the javascript that triggers the lookup

[sobkowicz]

I tested this patch (by jonbishop) and it appears to work. I think taking out this functionality is fine as well.

[SergeyBiryukov]

23322.patch​ looks good to me.

23322.2.patch​ removes a couple more references.

[jonbishop]

Incorporated the fixes from 23322.2.patch​ into 23322.3.patch​ which removes wordLookup from the localized quicktagsL10n array that gets added to the header in the admin.

[SergeyBiryukov]

I guess dictionaryLookup and lookup can be removed too.

[jonbishop]

Removed dictionaryLookup and lookup

[nacin]

In 24052:

Remove ancient 'lookup' quicktag from the text editor. This had called up answers.com.

props mboynes, jonbishop, SergeyBiryukov.
fixes #23322.

[nacin]

I decided to leave qt.SpellButton = function() {]; in there, just to avoid potential JS errors with plugins.