![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
#23322 closed defect (bug) (fixed)
The lookup in text editor does nothing when I enter text in hebrew
| Reported by: | mark-k | Owned by: | nacin |
|---|---|---|---|
| Priority: | normal | Milestone: | 3.6 |
| Component: | Editor | Version: | |
| Severity: | minor | Keywords: | has-patch commit |
| Cc: | Focuses: |
Description
- In the text editor Click lookup
- In the window enter hebrew text and submit
- Window closes but nothing else happens
For english text a tab is opened with proper page from answers.com or a "can't find" page.
Several questions
- What is the purpose of that button?
- Why answers.com? It is hardcoded in JS
- If this is useful, why there is no such button in the visual editor?
Attachments (6)
Change History (17)
#4
@
13 years ago
- Cc added
- Keywords has-patch needs-testing added
I agree, this is pretty useless. Sorry answers.com, no more free traffic for you.
I just added a patch that removes the button from the toolbar, but doesn't remove the functionality (in the event that someone uses it, this will allow them to add it back very easily). I moved the "close" button up in the array as well from key 140 to key 130.
#5
@
13 years ago
Do we want to leave the functionality in there? I feel like it's easy enough to add back in as a plugin and why leave something like that hidden in core.
Also, don't we need to remove 'spell' from the quicktag settings anywhere we manually call the editor?
@
13 years ago
This removes all references to 'spell' in quicktags args and the javascript that triggers the lookup
#6
@
13 years ago
- Cc added
I tested this patch (by jonbishop) and it appears to work. I think taking out this functionality is fine as well.
#7
@
13 years ago
- Keywords commit added; needs-testing removed
23322.patch looks good to me.
23322.2.patch removes a couple more references.
#8
follow-up:
↓ 9
@
13 years ago
- Cc added
Incorporated the fixes from 23322.2.patch into 23322.3.patch which removes wordLookup from the localized quicktagsL10n array that gets added to the header in the admin.
This appears to be some kind of Spell button in Quicktags: http://core.trac.wordpress.org/browser/trunk/wp-includes/js/quicktags.js#L502
I would assume that Hebew text doesn't pass as "word" characters in Javascript regular expressions causing nothing to happen.
I uh, vote to remove the button myself, it doesn't appear to be anything of use, When it was added 9 years ago, answers.com may have actually been useful.
For reference, answers.com was added in [2476] (previously it was dictionary.reference.com, which was either present in b2, or added somewhere around WordPress changeset [300]).