Opened 11 years ago
Last modified 23 months ago
#23327 new enhancement
Cache incrementors for get_bookmarks()
Reported by: |
|
Owned by: | |
---|---|---|---|
Milestone: | Priority: | low | |
Severity: | normal | Version: | 3.5.1 |
Component: | Cache API | Keywords: | has-patch |
Focuses: | Cc: |
Attachments (2)
Change History (13)
#3
@
10 years ago
- Milestone changed from 3.7 to Future Release
- Priority changed from normal to low
Needs a patch.
#5
follow-up:
↓ 6
@
9 years ago
I had a slight problem with figuring out how to create a unit-test that would consider the current 'defaults' from get_bookmarks, since that data is only available in the function itself.
This is the most important part in the generation of the cache key, so it will be very difficult to test without knowing this and not have it break when the defaults might be modified in the future.
Any advice/suggestions on that?
#6
in reply to:
↑ 5
;
follow-up:
↓ 7
@
9 years ago
Replying to jipmoors:
This is the most important part in the generation of the cache key, so it will be very difficult to test without knowing this and not have it break when the defaults might be modified in the future.
Link manager is disabled for new installs (see #21307), so it's very unlikely for those defaults to change.
#7
in reply to:
↑ 6
@
9 years ago
Replying to SergeyBiryukov:
Link manager is disabled for new installs (see #21307), so it's very unlikely for those defaults to change.
Alright, I'll write a test for it then and put some additional commentary in there. Thanks for the reply.
#8
@
9 years ago
- Keywords needs-unit-tests removed
Please be critical about the unit tests, these are a couple of my first ones so I'm sure there is room for improvement.
On a side note (not an excuse): the bookmarks are kind of old and should not take up too much energy and time I think.
these are all marked 3.7-early