WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 19 months ago

#23331 closed enhancement (maybelater)

Gmagick support

Reported by: markoheijnen Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Media Keywords: has-patch 3.7-early
Focuses: Cc:

Description

In 3.5 we added Imagick support. It would be great to also include Gmagick. Since Graphicmagick is just more awesome then ImageMagick.

Attachments (3)

23331.diff (12.3 KB) - added by markoheijnen 2 years ago.
First try. Code from http://wordpress.org/extend/plugins/gmagick/
23331.2.diff (12.3 KB) - added by markoheijnen 2 years ago.
Change version number to 3.6.0 and also add [23750] to this patch
23331.3.diff (12.3 KB) - added by dh-shredder 2 years ago.
Same patch, but with Gmagick last in line.

Download all attachments as: .zip

Change History (13)

comment:1 @markoheijnen2 years ago

  • Keywords has-patch added

comment:2 @nacin2 years ago

Sweet.

comment:3 @dh-shredder2 years ago

If we're going to go for Gmagick support in 3.6, I'd suggest dropping it in for a soak as soon as we can, so that we can discover any hosting compatibility issues that might arise.

My only hesitation would be that there's less hosting support for Gmagick than Imagick. That said, it's pretty clear that Gmagick/Graphicsmagick is the way forward, both due to its developers support, and performance concerns.

comment:4 @markoheijnen2 years ago

  • Keywords commit added

@markoheijnen2 years ago

Change version number to 3.6.0 and also add [23750] to this patch

comment:5 @markoheijnen2 years ago

Can we commit this? The code is pretty robust because it's almost the same at imagick. We do need user tests. I'm already running this code before 3.5 was even launched and never had issues.

@dh-shredder2 years ago

Same patch, but with Gmagick last in line.

comment:6 @dh-shredder2 years ago

As requested in dev chat, same patch, but with Gmagick last in line: 23331.3.diff

comment:7 @nacin2 years ago

  • Keywords 3.7-early added; commit removed
  • Milestone changed from 3.6 to Future Release

We load all core editors, even if we chose an earlier one first. So let's do this in 3.7, possibly reworking this to only include gmagick when it makes sense. Unfortunately we can't stop including GD and IM as classes may already be extending them.

comment:8 @markoheijnen2 years ago

Don't see why it needs to get another flow. Loading the editors isn't something really heavy.

comment:9 @wonderboymusic20 months ago

  • Milestone changed from Future Release to 3.7

these are all marked 3.7-early

comment:10 @nacin19 months ago

  • Milestone 3.7 deleted
  • Resolution set to maybelater
  • Status changed from new to closed

I've chatted with markoheijnen about this. According to some research, Gmagick has an install base of roughly 0% of WordPress sites. (The same sampling showed that GD was available on 95-98%+ of installs, Imagick on 25%.) So for the time being, this belongs in a plugin.

Note: See TracTickets for help on using tickets.