Update to jQuery UI 1.10.*

[ocean90]

Release post: ​http://blog.jqueryui.com/2013/01/jquery-ui-1-10-0/

[ocean90]

Because of the ​Dialog API Redesign (​Upgrade Guide) there is an issue with the edit/insert link dialog, see ​http://cl.ly/Md0u

[nacin]

In 23423:

jQuery UI 1.10.0.

Some lingering issues with the edit/insert link dialog.

props ocean90.
see #23370.

[ocean90]

Replying to ocean90:

Because of the ​Dialog API Redesign (​Upgrade Guide) there is an issue with the edit/insert link dialog, see ​http://cl.ly/Md0u

[ocean90]

jQuery UI 1.10.1

[ocean90]

23370.2.patch​: jQuery UI 1.10.1

• ​http://blog.jqueryui.com/2013/02/jquery-ui-1-10-1/
• ​http://jqueryui.com/changelog/1.10.1/

Dialog unchanged.

[nacin]

In 23442:

jQuery UI 1.10.1.

props ocean90. see #23370.

[ocean90]

23370.3.patch​:

• Syncs the jQuery UI CSS styles with the current one
• Hardcodes the old z-index values, since the zIndex attribute is ​gone
• Fixes the close button

Patch tested in Chrome, Opera, Safari Firefox, IE 7-10. RTL tested too.

[ocean90]

Another issue:

Open DFW and switch to text mode. Add a link. Link will be added but you get an error too:

Uncaught TypeError: Cannot call method '_focusTabbable' of undefined j
query.ui.dialog.min.js:5
(anonymous function) jquery.ui.dialog.min.js:5
jQuery.event.dispatch jquery.js:3074
elemData.handle jquery.js:2750
jQuery.event.trigger jquery.js:2986
jQuery.event.trigger jquery-migrate.js:468
jQuery.event.simulate jquery.js:3301
handler jquery.js:3552
wpLink.htmlUpdate wplink.js:212
wpLink.update wplink.js:158
(anonymous function) wplink.js:35
jQuery.event.dispatch jquery.js:3074
elemData.handle

Related: ​http://bugs.jqueryui.com/ticket/9000

[ocean90]

refresh of .3

[nacin]

Is there an upstream regression fixed by 23370.4.patch​?

Is the issue in comment 7 still an issue in 1.10.1? If so, do we need to report something upstream?

[ocean90]

Is there an upstream regression fixed by 23370.4.patch​?

Yesno. They removed support for a zindex property.

Is the issue in comment 7 still an issue in 1.10.1?

Yes.

If so, do we need to report something upstream?

No. ​http://bugs.jqueryui.com/ticket/9097

[nacin]

Also, here is where zindex was removed. Not a major issue, they just no longer wanted to juggle z-index and would prefer that it is left to CSS. ​http://bugs.jqueryui.com/ticket/8729

[nacin]

In 23515:

Fix internal linking dialog conflicts with jQuery UI 1.10.x. Syncs jQuery UI CSS styles.

Remaining issue will be fixed in 1.10.2 final.
props ocean90.
see #23370.

[ocean90]

So, waiting for 1.10.2.

[ocean90]

23370.5.patch​ fixes the issue from comment:7.

• ​http://blog.jqueryui.com/2013/03/jquery-ui-1-10-2/
• ​http://jqueryui.com/changelog/1.10.2/

[ocean90]

UI 1.10.2

[nacin]

In 23892:

jQuery UI 1.10.2.

props ocean90. fixes #23370.

[programmin]

This is causing a z-index conflict in /wp-includes/css/jquery-ui-dialog.css:

.ui-widget-overlay {
 z-index: 300001;

is over

.ui-front {
 z-index: 100;

A new dialog has its shadow in front of it, you can't click 'close'. For example, try this on a wp-admin page:

var msg = '<div>hello</div>';
jQuery(msg).dialog({ draggable: false, resizable: false, modal: true });

The close button and the form are behind the overlay.

[adamsilverstein]

i checked into the issue you reported on the dialog not loading correctly. your code indeed shows the dialog behind the overlay, oops! i figured out you need do do something slightly different, nothing is wrong with the CSS!

not sure if this is documented anywhere, but it looks like you need to add the wp-dialog class to your dialogs to get them to show up properly in the admin interface, try this update of your example to see what happens, you should see the modal:

var msg = '<div>hello this is a test</div>';
jQuery(msg).dialog({ draggable: false, resizable: false, modal: true, dialogClass: 'wp-dialog' });

Replying to programmin:

This is causing a z-index conflict in /wp-includes/css/jquery-ui-dialog.css:

.ui-widget-overlay {
 z-index: 300001;

is over

.ui-front {
 z-index: 100;

A new dialog has its shadow in front of it, you can't click 'close'. For example, try this on a wp-admin page:

var msg = '<div>hello</div>';
jQuery(msg).dialog({ draggable: false, resizable: false, modal: true });

The close button and the form are behind the overlay.

[ocean90]

jQuery UI 1.10.3

[ocean90]

23370.6.patch​:

• ​http://blog.jqueryui.com/2013/05/jquery-ui-1-10-3/
• ​http://jqueryui.com/changelog/1.10.3/

[ocean90]

In 24204:

jQuery UI 1.10.3. fixes #23370.