Make WordPress Core

Opened 12 years ago

Closed 10 years ago

#23371 closed defect (bug) (wontfix)

Subdir front-end Toolbar bug on first login

Reported by: drewapicture's profile DrewAPicture Owned by:
Milestone: Priority: normal
Severity: normal Version: 3.3
Component: Toolbar Keywords: dev-feedback has-patch needs-testing
Focuses: Cc:

Description

In an obscure set of circumstances, I encountered a small bug where the Toolbar doesn't display on the front-end of a subdirectory install on the first login where the site URL points to the root domain.

show_admin_bar_front is rightly set to true both on first and second+ logins, but the Toolbar doesn't display on the front-end. The js isn't even being loaded.

I can reproduce this all the way back to 3.3.

To reproduce:

  1. Install a fresh copy of WordPress in a subdirectory.
  2. Login.
  3. Change site url to point to the main domain.
  4. Visit the front-end, observe the Toolbar isn't displayed.
  5. Logout.
  6. Login again.
  7. Re-visit the front-end, observe the Toolbar now displays as expected.

I'm unable to trace back what's causing the Toolbar not to be displayed after the initial login. Maybe we should just force the user to login again after changing the site url.

Attachments (1)

23371.patch (407 bytes) - added by SergeyBiryukov 12 years ago.

Download all attachments as: .zip

Change History (7)

#2 @SergeyBiryukov
12 years ago

This happens when a front-end cookie with the new path doesn't exist yet. We could probably force a re-login in update_home_siteurl() (23371.patch), which would fix #13779 as well.

wp_set_auth_cookie() wouldn't work there, since COOKIEPATH still has the old value.

#3 @DrewAPicture
12 years ago

  • Keywords has-patch needs-testing added

#4 @DrewAPicture
10 years ago

  • Keywords close added

@SergeyBiryukov: Any interest in pursing this fix? Or should we just leave it?

#5 @DrewAPicture
10 years ago

  • Keywords close removed
  • Milestone changed from Awaiting Review to Future Release

Just ran into this again. Forgot I even created this ticket.

#6 @DrewAPicture
10 years ago

  • Milestone Future Release deleted
  • Resolution set to wontfix
  • Status changed from new to closed

I've decided this is pretty much an edge case. Closing as wontfix.

Note: See TracTickets for help on using tickets.