WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #23396, comment 21


Ignore:
Timestamp:
02/20/13 16:11:07 (14 months ago)
Author:
adamsilverstein
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #23396, comment 21

    initial v1  
    11looks like its straightforward to add a second handle to the slider. technically this is not a range slider, just a two handles slider. 
    22 
    3 the comparison code always compares the newer to the older revision, so i think it makes sense that the sliders can't overlap and also block each other. 
    4  
    5 for example: you have 10 revisions, by default you are comparing the current version to the 1st (most recent) revision (or another revision if you clicked on it in the list perhaps).  the current version would be represented by the leftmost position on the slider, the next spot to the right would be the 1st revision now, you drag the right hand slider handle to the right so you are comparing say current to revision 8. next, you drag the left hand slider handle to the right, which shows comparisons between the revision you drag to (left) and revision 8 (right), but you can't go past revision 7 (one to the left of where the right handle is set). you leave the left handle at revision 3, the display is comparing revision 3 & revision 8. at this point, you can start dragging the right handle and you are viewing diffs from revision. again the right handle is bound by the left, so you can't go past revision 4 one to the right of the left handle. 
    6  
    7 this logic is a visual representation of what the current code actually does, it always compares newer->older, and it doesn't allow you to compare a revision to itself (although its fun to try). the left handle is the left revision and the right handle is the right revision. 
     3the code always compares newer->older, and it doesn't allow you to compare a revision to itself (although its fun to try). the left handle is the left revision and the right handle is the right revision. my plan is that if you drag one handle past another, when you let go they just 'swap' so you are always comparing from the left handle to the right handle (newer to older).  if you drag one handle on top of another it won't stay there when you let go. 
    84 
    95thoughts?