WordPress.org

Make WordPress Core

Opened 2 years ago

Last modified 2 years ago

#23401 new enhancement

Pass $metadata to intermediate_image_sizes_advanced filter

Reported by: amereservant Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version: 3.5
Component: Post Thumbnails Keywords: has-patch
Focuses: Cc:

Description

I'm requesting that the following patch be added, which simply passes the $metadata for the image to be used for the new post thumbnail sizes to any filters hooking the intermediate_image_sizes_advanced filter in the wp_generate_attachment_metadata function.

The purpose of this is for altering the size of a custom thumbnail size based on the given image's dimensions. For example, I have a need for an post image size that's a minimum dimension size of 200px. The default behavior will allow me to specify a maximum dimension size, but not a minimum.
So by hooking this filter, I can alter the $sizes array and correct the size of my custom post thumbnail size based on the current image's dimensions.

Attachments (1)

image.php.patch (539 bytes) - added by amereservant 2 years ago.
Proposed filter variable

Download all attachments as: .zip

Change History (6)

@amereservant2 years ago

Proposed filter variable

comment:1 follow-up: @markoheijnen2 years ago

Interesting idea. You can't use the filter 'image_resize_dimensions' because of not knowing the image size and a custom image editor for this seems redundant.

comment:2 in reply to: ↑ 1 @amereservant2 years ago

Replying to markoheijnen:

Interesting idea. You can't use the filter 'image_resize_dimensions' because of not knowing the image size and a custom image editor for this seems redundant.

Yeap. I discovered it after hacking Viper007Bond's Regenerate Thumbnail plugin and trying to make a basic size check. I realized that a simple post thumbnail size hook wasn't possible, yet it could be by passing the $metadata as a var parameter to the filter.

It doesn't hurt the performance any to add this and it'd be useful to us geeks that dive way too far into WP code, attempting to write proper plugins.

comment:3 @SergeyBiryukov2 years ago

  • Milestone changed from Awaiting Review to 3.6
  • Version changed from trunk to 3.5

comment:4 @DrewAPicture2 years ago

image.php.patch seems pretty straightforward, testing against the passed $metadata works for me.

comment:5 @ocean902 years ago

  • Milestone changed from 3.6 to Future Release
Note: See TracTickets for help on using tickets.