WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 21 months ago

#23406 closed defect (bug) (fixed)

Some notices messages which can maybe fixed

Reported by: uniterre Owned by:
Milestone: 3.7 Priority: normal
Severity: trivial Version: 3.5.1
Component: Inline Docs Keywords: has-patch dev-feedback
Focuses: Cc:

Description

Hi,

I use wordpress multisite on my own cms and I notice there are many notice messages when I load WP (include($wppath."includes/wp.inc.php") :

1) Declaration of Walker_Category::start_el() should be compatible with that of Walker::start_el()) in /wp-includes/category-template.php line 902

2) Declaration of WP_Scripts::set_group() should be compatible with that of WP_Dependencies::set_group()) in wp-includes/class.wp-scripts.php

3) Declaration of Walker_Nav_Menu::start_el() should be compatible with that of Walker::start_el()) in wp-includes/nav-menu-template.php

4) is_a(): Deprecated. Please use the instanceof operator) dans le fichier wp-includes/capabilities.php

Hope it helps
Regards,
Alexandre

Attachments (5)

23406.diff (4.8 KB) - added by DrewAPicture 2 years ago.
Docs
23406.2.diff (4.9 KB) - added by DrewAPicture 2 years ago.
23406-wc-wcd.diff (4.3 KB) - added by DrewAPicture 2 years ago.
Walker_Category and Walker_CategoryDropdown
23406-wcc.diff (2.9 KB) - added by DrewAPicture 2 years ago.
Walker_Category_Checklist
23406-walker.diff (9.7 KB) - added by DrewAPicture 2 years ago.
Walker

Download all attachments as: .zip

Change History (16)

comment:1 @nacin3 years ago

Please update to PHP 5.3, where is_a() is no longer deprecated.

The others appear to be valid issues:

wp-includes/class.wp-dependencies.php
223:	function set_group( $handle, $recursion, $group ) {

wp-includes/class.wp-scripts.php
161:	function set_group( $handle, $recursion, $group = false ) {
wp-admin/includes/nav-menu.php
37:	function start_el(&$output, $item, $depth, $args) {
238:	function start_el(&$output, $item, $depth, $args) {

wp-includes/category-template.php
823:	function start_el( &$output, $category, $depth = 0, $args = array(), $id = 0 ) {

wp-includes/nav-menu-template.php
67:	function start_el( &$output, $item, $depth = 0, $args = array(), $id = 0 ) {

comment:2 @wonderboymusic2 years ago

  • Keywords needs-docs added
  • Milestone changed from Awaiting Review to 3.7

These have since been rehabilitated, but the doc blocks on the methods are out of sync

@DrewAPicture2 years ago

Docs

comment:3 @DrewAPicture2 years ago

  • Component changed from Warnings/Notices to Inline Docs
  • Keywords has-patch dev-feedback added; needs-docs removed

@wonderboymusic: Did I miss any in 23406.2.diff?

Last edited 2 years ago by DrewAPicture (previous) (diff)

@DrewAPicture2 years ago

@DrewAPicture2 years ago

Walker_Category and Walker_CategoryDropdown

@DrewAPicture2 years ago

Walker_Category_Checklist

comment:4 @DrewAPicture2 years ago

In 25641:

Inline documentation improvements for Walker_Category and Walker_CategoryDropdown.

Also covers previously undocumented parameters.

See #23406, #19249.

comment:5 @DrewAPicture2 years ago

In 25642:

Inline documentation for Walker_Category_Checklist.

See #23406.

comment:6 @DrewAPicture2 years ago

In 25643:

Improve inline documentation for Walker_Nav_Menu, Walker_Nav_Menu_Edit, Walker_Nav_Menu_Checklist.

Includes previously undocumented parameters.

See #23406.

@DrewAPicture2 years ago

Walker

comment:7 @DrewAPicture2 years ago

In 25644:

Improve inline documentation for the Walker class.

Includes previously undocumented parameters.

See #23406.

comment:8 @DrewAPicture2 years ago

  • Resolution set to fixed
  • Status changed from new to closed

[25641], [25642], [25643], [25644] should cover the inconsistencies in documentation mentioned here.

[25524] handled docs for WP_Dependencies, and improvements to WP_Styles docs will be handled in a future ticket.

comment:9 @jfarthing8421 months ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

As far as I understand, 5.2.4 is still the "minimum" version for WordPress. In 5.2.4, is_a is deprecated. Perhaps either is_a shouldn't be used, or the "minimum" version should be bumped to 5.3, where it was reintroduced.

comment:10 @jfarthing8421 months ago

  • Cc jeff@… added

comment:11 @markoheijnen21 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

This ticket was closed on a complete milestone. Also the reason for increasing PHP in this case is invalid.

See #25672 for your concern.

Note: See TracTickets for help on using tickets.