WordPress.org

Make WordPress Core

Changes between Version 1 and Version 2 of Ticket #23421, comment 15


Ignore:
Timestamp:
02/28/2020 09:07:12 PM (8 months ago)
Author:
cr0ybot
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #23421, comment 15

    v1 v2  
    1 I took a crack at this in 23421.2.diff—it's a more complicated feature than it seems on the face of it. Most notably, ordering by a taxonomy column, where multiple terms may be present on a single post, actually means ordering by the plain-text list of terms concatenated. So any posts with just "Term A" applied will be grouped, and then a post with "Term A, Term B" will come after.
     1I took a crack at this in 23421.3.diff—it's a more complicated feature than it seems on the face of it. Most notably, ordering by a taxonomy column, where multiple terms may be present on a single post, actually means ordering by the plain-text list of terms concatenated. So any posts with just "Term A" applied will be grouped, and then a post with "Term A, Term B" will come after.
    22
    33The biggest change to the SQL was to put the taxonomy table joins into a subselect so that we don't drop posts without any terms.
     
    88
    99NOTE: I accidentally included another commit, I'm attempting to clean it up now...
     10
     11EDIT: Fixed patch file 23421.3.diff uploaded. Sorry about that.