Make WordPress Core

Opened 11 years ago

Closed 11 years ago

Last modified 9 years ago

#23426 closed defect (bug) (fixed)

Quick/Bulk Edit shouldn't allow changing of the post format

Reported by: helen's profile helen Owned by: ryan's profile ryan
Milestone: 3.6 Priority: normal
Severity: normal Version:
Component: Quick/Bulk Edit Keywords: has-patch commit
Focuses: Cc:


Given that a format's value is in its data and UI handling, it doesn't make much sense to allow changes to the post format in Quick/Bulk Editing, as you lose the special context.

Attachments (1)

23426.diff (2.5 KB) - added by kovshenin 11 years ago.

Download all attachments as: .zip

Change History (7)

#1 @helen
11 years ago

  • Keywords needs-patch added

11 years ago

#2 @kovshenin
11 years ago

  • Cc kovshenin added
  • Keywords has-patch added; needs-patch removed

23426.diff removes post formats from Quick Edit and the Quick Edit handler.

#3 @helen
11 years ago

  • Keywords commit added

Looks good to me.

#4 @ryan
11 years ago

  • Owner set to ryan
  • Resolution set to fixed
  • Status changed from new to closed

In 23742:

Don't allow changing the post format from quick edit and bulk edit. These do not have sufficient context to set the post format.

Props kovshenin
fixes #23426

#5 @alexvorn2
11 years ago

I think this was a mistake.
Better to improve and to add something then just remove...
In the Quick Edit box we could add some inputs appearing and disappearing like the edit post page...

related #24096

Version 1, edited 11 years ago by alexvorn2 (previous) (next) (diff)

#6 @afercia
9 years ago

In 36375:

Quick/Bulk Edit: Remove a no more used jQuery loop for unsupported post formats.

See #23426.
See #24096.
Fixes #35564.

Note: See TracTickets for help on using tickets.